Bug 198765
| Summary: | [PATCH] www/links: Make EGD conditional/Fix build with LibreSSL | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Bernard Spil <brnrd> | ||||||||||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||||||||||||
| Status: | Closed Overcome By Events | ||||||||||||||||||
| Severity: | Affects Some People | Keywords: | patch | ||||||||||||||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(bf) |
||||||||||||||||
| Version: | Latest | ||||||||||||||||||
| Hardware: | Any | ||||||||||||||||||
| OS: | Any | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
Created attachment 154621 [details]
Poudriere build log for www/links
I agree that we want to support LibreSSL, but this patch is far too large and unwieldy. I'll advise upstream of the problem, and distill a smaller set of changes from the patch. Created attachment 155969 [details]
svn diff for www/links
Hi Brendan,
The large patch is largely due to the autoconf version of the included configure script
+-# Generated automatically using autoconf version 2.13
++# Generated by GNU Autoconf 2.69.
I've refactored the patch so configure only adds the libcrypto RAND_egd check making the patch a lot smaller. Works fine here!
Created attachment 155970 [details]
Poudriere build log for www/links
Created attachment 156043 [details]
svn diff for www/links 2.9,1
Patch updated for 2.9,1
Created attachment 156044 [details]
Poudriere build log for www/links 2.9,1
Created attachment 162413 [details]
svn diff for www/links 2.9,1
After the addition of the OPENSSL_NO_EGD define the patch can be greatly reduced as requested by maintainer.
Maintainer reset. Version 2.13 fixes building without RAND_egd |
Created attachment 154620 [details] svn diff for www/links www/links unconditionally relies on RAND_egd which makes building fail with LibreSSL which has removed EGD. FreeBSD does not require EGD at all, /dev/random has been available since FreeBSD 4.2 This patch checks for the existence of RAND_egd in libcrypto and disables the code using egd.