Bug 198807

Summary: devel/librest: Update to 0.7.93
Product: Ports & Packages Reporter: Christoph Moench-Tegeder <cmt>
Component: Individual Port(s)Assignee: Pawel Pekala <pawel>
Status: Closed FIXED    
Severity: Affects Only Me CC: pawel
Priority: --- Keywords: needs-qa, patch
Version: LatestFlags: cmt: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
update to librest 0.7.93
cmt: maintainer-approval+
qa: make...stage-qa output
none
portlint -AC none

Description Christoph Moench-Tegeder freebsd_committer freebsd_triage 2015-03-22 21:34:30 UTC
Created attachment 154679 [details]
update to librest 0.7.93

librest 0.7.93 is out, and has fixes for all the thing we're carrying patches locally: https://git.gnome.org/browse/librest/

$ svn status
M       Makefile
M       distinfo
D       files
D       files/patch-rest_oauth-proxy-call.c
D       files/patch-tests_custom-serialize.c
D       files/patch-tests_threaded.c

Committer: please note removal of files/ directory and all three patches.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2015-03-23 07:23:43 UTC
QA results would be helpful here:

- Attach portlint -AC output
- Attach poudriere testport or bulk -t output

Great work setting flags!
Comment 2 Christoph Moench-Tegeder freebsd_committer freebsd_triage 2015-03-23 21:06:55 UTC
portlint:
cmt@elch:librest$ portlint -AC
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 1 warning found.

poudriere... needs jailbuilding, so please indulge me.
OTOH even the upstream changes are rather compact, so I do not expect the port to end up worse than it's now.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2015-03-23 23:53:49 UTC
QA as *attachments* please :)

In the absence of poudriere results (highly preferred and recommended long term), you can use:

make stage && make check-plist && make stage-qa && make package
Comment 4 Christoph Moench-Tegeder freebsd_committer freebsd_triage 2015-03-24 19:32:00 UTC
Created attachment 154772 [details]
qa: make...stage-qa output
Comment 5 Christoph Moench-Tegeder freebsd_committer freebsd_triage 2015-03-24 19:32:29 UTC
Created attachment 154773 [details]
portlint -AC
Comment 6 Christoph Moench-Tegeder freebsd_committer freebsd_triage 2015-03-24 19:34:17 UTC
ok, let's try these.

Is this documented somewhere (I couldn't find anything in the porter's handbook)? It feels like the process changes at least as often as I submit patches, which results in more round-trips than strictly neccessary :)
Comment 7 commit-hook freebsd_committer freebsd_triage 2015-03-30 15:12:22 UTC
A commit references this bug:

Author: pawel
Date: Mon Mar 30 15:12:19 UTC 2015
New revision: 382674
URL: https://svnweb.freebsd.org/changeset/ports/382674

Log:
  Update to version 0.7.93

  PR:		198807
  Submitted by:	cmt@burggraben.net (maintainer)

Changes:
  head/devel/librest/Makefile
  head/devel/librest/distinfo
  head/devel/librest/files/