Bug 198933

Summary: amdtemp(4) supports AMD 16h family processors (Kabini) but this is not reflected in it's man page
Product: Documentation Reporter: isoa
Component: Books & ArticlesAssignee: freebsd-doc (Nobody) <doc>
Status: Closed FIXED    
Severity: Affects Some People CC: brueffer
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   

Description isoa 2015-03-26 19:17:25 UTC 
Support for AMD 16h family processors, such as Kabini, was added to amdtemp(4) in the following pr: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=186587

My computer has such a processor (AMD A4 / Kabini, quad core), and I can verify amdtemp(4) works in FreeBSD 10.1:

# uname -a 
FreeBSD xxx.xxx 10.1-RELEASE-p6 FreeBSD 10.1-RELEASE-p6 #0: Tue Feb 24 18:57:59 UTC 2015     root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  i386
# dmesg
...
CPU: AMD A4-5000 APU with Radeon(TM) HD Graphics     (1497.22-MHz 686-class CPU)
  Origin = "AuthenticAMD"  Id = 0x700f01  Family = 0x16  Model = 0x0  Stepping = 1
...
# kldload amdtemp
amdtemp0: <AMD CPU On-Die Thermal Sensors> on hostb5
# sysctl -a | grep amdtemp
dev.amdtemp.%parent:
dev.amdtemp.0.%desc: AMD CPU On-Die Thermal Sensors
dev.amdtemp.0.%driver: amdtemp
dev.amdtemp.0.%location:
dev.amdtemp.0.%pnpinfo:
dev.amdtemp.0.%parent: hostb5
dev.amdtemp.0.sensor_offset: 0
dev.amdtemp.0.core0.sensor0: 61,3C

However, when the man page for amdtemp(4) only mentions the following:
...
DESCRIPTION
     The amdtemp driver provides support for the on-die digital thermal sensor
     present in AMD Family 0Fh, 10h, 11h, 12h, 14h, and 15h processors.
...

To me it seems like the man page should mention 16h AMD processor family being supported.
Comment 1 commit-hook freebsd_committer freebsd_triage 2015-03-27 17:15:28 UTC 
A commit references this bug:

Author: brueffer
Date: Fri Mar 27 17:15:18 UTC 2015
New revision: 280765
URL: https://svnweb.freebsd.org/changeset/base/280765

Log:
  Mention support for 16h family processors, added in r263169.

  PR:		198933
  Submitted by:	isoa@kapsi.fi
  MFC after:	1 week

Changes:
  head/share/man/man4/amdtemp.4
Comment 2 Christian Brueffer freebsd_committer freebsd_triage 2015-03-27 17:17:05 UTC 
I forgot to update the manpage after committing 16h support indeed.  Thanks for the PR!
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-04-07 15:24:54 UTC 
A commit references this bug:

Author: brueffer
Date: Tue Apr  7 15:24:38 UTC 2015
New revision: 281205
URL: https://svnweb.freebsd.org/changeset/base/281205

Log:
  MFH: r280765

  Mention support for 16h family processors, added in r263169.

  PR:		198933
  Submitted by:	isoa@kapsi.fi

Changes:
_U  stable/10/
  stable/10/share/man/man4/amdtemp.4