Bug 198935
| Summary: | [MAINTAINER] net/p5-SOAP-Lite: update to 1.14 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Sergei Vyshenski <svysh.fbsd> | ||||||
| Component: | Individual Port(s) | Assignee: | Po-Chuan Hsieh <sunpoet> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | sunpoet, svysh.fbsd | ||||||
| Priority: | --- | Keywords: | patch, patch-ready | ||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Bug Depends on: | 198934 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Sergei Vyshenski
2015-03-26 20:57:20 UTC
Created attachment 154846 [details]
log from poudriere at 10.1-amd64
looks good, promoting! Please do not forget PR 198934, from which this one depends. (In reply to Sergei Vyshenski from comment #0) The patch of *_DEPENDS is incorrect. I'll fix it with the following changes: - Add www/p5-LWP-Protocol-https - Remove security/p5-Crypt-SSLeay - Use TEST_DEPENDS for test-only dependencies (devel/p5-Test-Warn, devel/p5-Test-XML and textproc/p5-XML-Parser-Lite) I would also sort *_DEPENDS to make it easier to check dependency changes. Thank you very much for your note. - www/p5-LWP-Protocol-https should be added. My fault. - If we remove security/p5-Crypt-SSLeay, then we should add security/p5-Net-SSLeay, which is more along the line of the author. My fault again. - textproc/p5-XML-Parser-Lite is explicitly required during run-time, and thus should be kept intact. It is a new run-time dependency starting from this version of net/p5-SOAP-Lite. - devel/p5-Test-Warn and devel/p5-Test-XML are really needed for test only. I have added them to BUILD_DEPENDS, because poudriere does not support TEST_DEPENDS at the moment. The only known way to run built-in tests from within poudriere jail, is to include everything into BUILD_DEPENDS, and to activate "pre-install: test" construct in the port's Makefile. The last workaround was offered by mat@ following my question at the perl@ list. Do you want me to prepare a new patch and a new test log? If yes, what would be your decision about points above? Oh, I was wrong again: security/p5-Net-SSLeay is a direct dependency of www/p5-LWP-Protocol-https and sure need not be added separately. I'll move p5-XML-Parser-Lite back to {BUILD,RUN}_DEPENDS.
I was using tinderbox to build p5-* ports since it supports TEST_DEPENDS. In order to run regression-test: in poudriere, it's recommended to patch perl5.mk locally with add TEST_DEPENDS to BUILD_DEPENDS and.
I would suggest to remove "#pre-install: test" from Makefile.
OK. Do you want me to prepare a new patch and a new test log? A commit references this bug: Author: sunpoet Date: Sat Mar 28 19:06:03 UTC 2015 New revision: 382542 URL: https://svnweb.freebsd.org/changeset/ports/382542 Log: - Update to 1.14 - Sort PLIST - While I'm here: - Fix *_DEPENDS: - Add www/p5-LWP-Protocol-https - Remove security/p5-Crypt-SSLeay - Use TEST_DEPENDS for devel/p5-Test-Warn and devel/p5-Test-XML - Sort *_DEPENDS Changes: http://search.cpan.org/dist/SOAP-Lite/Changes PR: 198935 Submitted by: Sergei Vyshenski <svysh.fbsd@gmail.com> (maintainer) Changes: head/net/p5-SOAP-Lite/Makefile head/net/p5-SOAP-Lite/distinfo head/net/p5-SOAP-Lite/pkg-plist Committed. Thanks! |
