Summary: | [PATCH] security/nessus-libraries Fix build with LibreSSL | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Bernard Spil <brnrd> | ||||||||
Component: | Individual Port(s) | Assignee: | Carlo Strub <cs> | ||||||||
Status: | Closed FIXED | ||||||||||
Severity: | Affects Some People | CC: | Udo.Schweigert, cs, jamie | ||||||||
Priority: | --- | Keywords: | patch | ||||||||
Version: | Latest | Flags: | Udo.Schweigert:
maintainer-feedback+
|
||||||||
Hardware: | Any | ||||||||||
OS: | Any | ||||||||||
Attachments: |
|
Created attachment 154933 [details]
Poudirere build log of security/nessus-libraries
Created attachment 154934 [details]
Poudriere build log of security/nessus-libnasl
Added as that was originally failing, not the -libraries port...
Nice one! I'd too noticed the SSL patches applied a few weeks ago were not working with the nessus ports, but hadn't got around to trying to find out why! cheers, Jamie (In reply to Jamie Landeg-Jones from comment #3) Hi Jamie, Be sure to check https://wiki.freebsd.org/LibreSSL, https://wiki.freebsd.org/OpenSSL and sub-pages. I'm trying to keep track of all of 'm Great work. Thanks. I tested and approve the change. To get it working you will have to delete nessus-libraries/files/patch-libnessus__network.c from the port as this is incorporated into the new patch. Udo A commit references this bug: Author: cs Date: Tue Sep 15 23:59:10 UTC 2015 New revision: 397032 URL: https://svnweb.freebsd.org/changeset/ports/397032 Log: Fix build with LibreSSL PR: 198992 Submitted by: brnrd@ Approved by: maintainer Changes: head/security/nessus-libraries/Makefile head/security/nessus-libraries/files/patch-Makefile head/security/nessus-libraries/files/patch-libnessus__network.c head/security/nessus-libraries/files/patch-libnessus_network.c head/security/nessus-libraries/files/patch-libpcap-nessus__configure Committed. Thank you very much. |
Created attachment 154932 [details] svn diff for security/nessus-libraries The security/nessus-libraries doesn't properly detect OpenSSL or LibreSSL from base. This results in issues with LibreSSL as this doesn't have SSLv2 and due to the linker not getting the /usr/local bits passed building nessus-libnasl consequently fails. (I believe the existing patch removing SSLv2 is thus non-functional) This patch: - Defines USE_OPENSSL=yes - Passes proper --with-ssl= to configure - Already disables SSLv3 (we should)