Bug 199001

Summary: [MAINTAINER] textproc/p5-XML-Parser-Lite: fix PORTVERSION to 0.720
Product: Ports & Packages Reporter: Sergei Vyshenski <svysh.fbsd>
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Some People CC: svysh.fbsd
Priority: --- Flags: svysh.fbsd: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch for updating port
none
log from poudriere at 10.1-amd64 w/o perl tests
none
log from poudriere at 10.1-amd64 with perl tests none

Description Sergei Vyshenski 2015-03-29 11:57:16 UTC 
Created attachment 154961 [details]
patch for updating port

- change PORTVERSION from 0.72 to 0.720 to make portscout happy.
- add DISTNAME to fetch version 0.72, as author decided to call it so,
after previous version 0.719:
http://search.cpan.org/~phred/XML-Parser-Lite-0.72/

- "portlint -AC" just warns about non-empty $FreeBSD$ tag and about 
hyphen in PORTNAME.

- Tested with poudriere 3.1.99 at 10.1-amd64 with perl5-5.18.4_11.
Two variants of poudriere logs are attached: 
with and without activation of built-in perl tests.
To control built-in perl tests inside poudriere jails, 
Mk/Uses/perl5.mk was locally augmented with lines:

.if defined(RUN_PERL_TESTS)
BUILD_DEPENDS+= ${TEST_DEPENDS}
pre-install:    test
.endif # defined(RUN_PERL_TESTS)
Comment 1 Sergei Vyshenski 2015-03-29 11:57:46 UTC 
Created attachment 154962 [details]
log from poudriere at 10.1-amd64 w/o perl tests
Comment 2 Sergei Vyshenski 2015-03-29 11:58:11 UTC 
Created attachment 154963 [details]
log from poudriere at 10.1-amd64 with perl tests
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2015-03-30 13:19:08 UTC 
I would suggest not to hack PORTVERSION. The correct way is to add "PORTSCOUT=skipv:0.717,0.718,0.719" to tell portscout to ignore these old versions.
Comment 4 Sergei Vyshenski 2015-03-30 13:38:20 UTC 
Agreed. 
But in the future this author will release 0.73 after 0.729 and we will have to introduce a new PORTEPOCH or such? Maybe hacking of PORTVERSION is more consistent?
Also, in the file Changes:

http://cpansearch.perl.org/src/PHRED/XML-Parser-Lite-0.72/Changes

he names his versions as follows: 0.718, 0.719, 0.720
So I have not invented this number:  0.720
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2015-03-30 13:46:26 UTC 
IMHO, I would use PORTSCOUT right now and wait to see how the author name the following releases (0.xy or 0.xyz).
Comment 6 Sergei Vyshenski 2015-03-30 13:50:27 UTC 
Shall I submit a new patch, or you could kindly do this?
Comment 7 commit-hook freebsd_committer freebsd_triage 2015-03-30 13:52:14 UTC 
A commit references this bug:

Author: sunpoet
Date: Mon Mar 30 13:51:57 UTC 2015
New revision: 382670
URL: https://svnweb.freebsd.org/changeset/ports/382670

Log:
  - Add PORTSCOUT [1]
  - Cleanup Makefile

  PR:		199001
  Submitted by:	sunpoet (myself) [1]
  Approved by:	Sergei Vyshenski <svysh.fbsd@gmail.com> (maintainer)

Changes:
  head/textproc/p5-XML-Parser-Lite/Makefile
Comment 8 Po-Chuan Hsieh freebsd_committer freebsd_triage 2015-03-30 13:53:40 UTC 
Committed. Thanks!
Comment 9 Sergei Vyshenski 2015-03-30 13:57:20 UTC 
Thank you very much.
But do you think that we need to bump PORTREVISION for portscout to notice this change?
Comment 10 Po-Chuan Hsieh freebsd_committer freebsd_triage 2015-03-30 14:08:38 UTC 
Do you mean portscout.freebsd.org? It updates ports tree every 15 mins and the change we made is already applied. http://portscout.freebsd.org/svysh.fbsd@gmail.com.html shows that all ports are up-to-date now.
Comment 11 Sergei Vyshenski 2015-03-30 14:10:30 UTC 
Oh, yes. Thank you again.