Bug 199016

Summary: [textproc/ibus] [PATCH] Fixed gettext dependency
Product: Ports & Packages Reporter: Yuri Victorovich <yuri>
Component: Individual Port(s)Assignee: Jan Beich <jbeich>
Status: Closed FIXED    
Severity: Affects Only Me CC: henry.hu.sh
Priority: --- Keywords: patch
Version: LatestFlags: bugzilla: maintainer-feedback? (henry.hu.sh)
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch
none
poudriere log
none
patch to fix gettext and NLS
henry.hu.sh: maintainer-approval+
fix NLS henry.hu.sh: maintainer-approval+

Description Yuri Victorovich freebsd_committer freebsd_triage 2015-03-30 08:24:06 UTC
Created attachment 154985 [details]
patch

poudriere build currently fails when NLS=off due to unsatisfied gettext dependency.
Attaching new, successful poudriere log (with this patch).
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2015-03-30 08:28:31 UTC
Created attachment 154986 [details]
poudriere log
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2015-03-30 08:30:09 UTC
Please also fix this warning from configure:
> configure: WARNING: unrecognized options: --without-nls
- see it in poudriere log
Comment 3 Henry Hu 2015-04-11 07:13:49 UTC
Created attachment 155450 [details]
patch to fix gettext and NLS

Please try this patch.
Someone changed the Makefile to use NLS_CONFIGURE_WITH in r360404. However, he should have used NLS_CONFIGURE_ENABLE.
Even without NLS, gettext seems to be required for intltool.
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2015-04-11 07:39:44 UTC
Yes, with this patch it builds with and without NLS option.
Comment 5 Henry Hu 2015-04-13 01:25:57 UTC
Created attachment 155530 [details]
fix NLS

Well, someone has fixed the compilation with NLS=off.
Now just fix the configure argument. NLS_CONFIGURE_WITH should be NLS_CONFIGURE_ENABLE.
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-05-03 16:58:28 UTC
A commit references this bug:

Author: jbeich
Date: Sun May  3 16:57:34 UTC 2015
New revision: 385290
URL: https://svnweb.freebsd.org/changeset/ports/385290

Log:
  textproc/ibus: restore --disable-nls after r360404 switched to --without-nls

  PR:		199016
  Submitted by:	Henry Hu <henry.hu.sh@gmail.com> (maintainer)

Changes:
  head/textproc/ibus/Makefile
Comment 7 Jan Beich freebsd_committer freebsd_triage 2015-05-03 17:00:48 UTC
Thanks. Committed only followup for ports r383811.