Bug 199052
| Summary: | [PATCH] Use 7 alphanumeric GH_COMMIT for WRKSRC, related to "legacy.tar.gz" (codeload) GitHub backend method | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | lightside <lightside> | ||||
| Component: | Ports Framework | Assignee: | Port Management Team <portmgr> | ||||
| Status: | Closed Not Accepted | ||||||
| Severity: | Affects Some People | CC: | bdrewery, ports-bugs | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
|
Description
lightside
2015-03-30 22:18:16 UTC
I don't see any reason to change GH_COMMIT. It will be removed soon. Please convert ports using it. (In reply to Bryan Drewery from comment #1) > I don't see any reason to change GH_COMMIT. Really? This is not surprising, because you are the person, who committed related changes. (In reply to Bryan Drewery from comment #1) > Please convert ports using it. I already submitted related PRs. Some of the ports has a benefit, because they may use available tags, but some not, if there is a need to use full commit hash, i.e. very long directory name for WRKSRC. Overall, this is just a not needed (untimely) switch from one workable solution (legacy.tar.gz) to another (tar.gz), in my opinion. There was a possibility to use tags with proper changes, without the need to convert other ports. The one of the reasons to convert was a not supported longer abbreviated (or full) commit hash for GH_COMMIT method, which is wrong. But I agree, that this PR may be too late. There are other changes and public statements, which prevents it. Feel free to close this PR, if you don't need proposed changes. At least, there are no other expressed opinions here to this moment. (In reply to comment #2) > but some not, if there is a need to use full commit hash, i.e. very long directory name for WRKSRC. Realistically, the need for full commit hash may be rare (to this time). Even creation of repository with many commits takes time. Personally, I didn't find abbreviated commit hash, which equals to full commit hash for some existing large repositories. But this is logical conclusion to use full commit hash, if you may want your download method works for previous versions of port, independent from future changes to repository. What I said may be not related to concrete "legacy.tar.gz" or "tar.gz" GitHub backend methods. Technically, they are the same, but with different output, I guess. I think, the possible issue with long name for WRKSRC directory is solvable with renaming to short directory name, e.g.: WRKSRC= ${WRKDIR}/${PORTNAME} # ... post-extract: @(cd ${WRKDIR} && ${MV} ${GH_PROJECT}-* ${PORTNAME}) But this is what "legacy.tar.gz" GitHub backend method (potentially) does in result. In other words, there are solutions, independent from where current ports framework takes its development. If ports framework doesn't fit (or help), it's possible to create own proper methods, when needed. Closed. The proposed patch is not acceptable, based on comment #1. There is no reason to wait a possible GH_COMMIT deprecation. |
