Bug 199221
| Summary: | [PATCH] audio/sooperlooper: Fix build on 8.x | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | tkato432 | ||||||
| Component: | Individual Port(s) | Assignee: | John Marino <marino> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | marino | ||||||
| Priority: | --- | Keywords: | patch | ||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
actually, this doesn't currently build on FreeBSD 8. It will work on FreeBSD 10. Created attachment 155709 [details]
audio_sooperlooper.diff
Here is the corrected patch.
I don't think I like this approach. 1) Obviously it doesn't fix DragonFly 2) It doesn't fix the actual problem 3) If we downground to wx 2.8, I think all platforms should use 2.8. another approach is to turn off the WXGTK option A commit references this bug: Author: marino Date: Mon Apr 20 07:19:34 UTC 2015 New revision: 384334 URL: https://svnweb.freebsd.org/changeset/ports/384334 Log: audio/sooperlooper: Unbreak on some platforms This unmaintained port is breaking on Wx 3.0, which is only an GUI option. Downgrading to Wx 2.8 allows it to build on all platforms (as well as having the option by default). The second iteration of the PR suggested Wx3.0 for FreeBSD 8 and 9, but Wx 2.8 for F10+, but I didn't like that approach. It only works on F8 and F9 because of compiler deficiencies. Simple attempts of setting -std to c++11 didn't work, of course. PR: 199221 Submitted by: ports fury Changes: head/audio/sooperlooper/Makefile I went with the "2.8 everywhere" approach, thanks. |
Created attachment 155259 [details] audio_sooperlooper.diff