Bug 199246
| Summary: | [PATCH] multimedia/gtk-youtube-viewer: Update 3.1.9 | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | tkato432 | ||||||||||||||||||||||||
| Component: | Individual Port(s) | Assignee: | Thomas Zander <riggs> | ||||||||||||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||||||||||||
| Severity: | Affects Only Me | CC: | junovitch, riggs | ||||||||||||||||||||||||
| Priority: | --- | Keywords: | needs-qa, patch, patch-ready | ||||||||||||||||||||||||
| Version: | Latest | ||||||||||||||||||||||||||
| Hardware: | Any | ||||||||||||||||||||||||||
| OS: | Any | ||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||
Created attachment 155618 [details]
multimedia_gtk-youtube-viewer.diff
Version 3.1.3 has been released.
Created attachment 156710 [details]
multimedia_gtk-youtube-viewer.diff
Chase r385637
Created attachment 156716 [details]
multimedia_gtk-youtube-viewer.diff
Version 3.1.4 has been released.
Created attachment 156849 [details]
multimedia_gtk-youtube-viewer.diff
Version 3.1.5 has been released.
Created attachment 157175 [details]
multimedia_gtk-youtube-viewer.diff
Version 3.1.7 has been released.
Created attachment 157454 [details]
multimedia_gtk-youtube-viewer.diff
Version 3.1.8 has been released.
Thanks tkato, please attach QA results (portlint -AC, poudriere testport) as well Created attachment 157478 [details]
ac.txt
Created attachment 157479 [details]
testport.txt
Hello, Are you interested in becoming the maintainer for this port? Good work keeping your patches updated along the way. You are already most of the way there to being the maintainer. I noticed there is 3.1.9 release out on https://code.google.com/p/trizen/. Consider fixing the one QA issue noticed and doing that update and this should be commit ready. The only QA issue I noted is the following (which is in your ac.txt): WARN: Makefile: [46]: possible direct use of command "patch" found. use ${PATCH} instead. I've done successful Poudriere testport builds of your patch on the following and did not see anything that needed to be addressed in the output: 8.4-RELEASE-p31 amd64 8.4-RELEASE-p31 i386 9.3-RELEASE-p17 amd64 9.3-RELEASE-p17 i386 10.1-RELEASE-p14 amd64 10.1-RELEASE-p14 i386 11.0-CURRENT r284725 amd64 11.0-CURRENT r284725 i386 Created attachment 158484 [details]
multimedia_gtk-youtube-viewer.diff
WARN is nothing but a false positive. Although it's obvious that
USE_PERL5=patch doesn't mean direct use of patch command, portlint
doesn't seem to be aware of this syntax at all.
(In reply to tkato432 from comment #11) Excellent! I see what you are talking about now that I've looked at the Makefile. No QA issues then. Keep up the good work. I've retested your 3.1.9 update on the same range from comment 10 and there are no issue. This looks good for commit. Jason, could you attach one of your poudriere logs please. thanks! Created attachment 158528 [details] gtk-youtube-viewer-3.1.9.log (In reply to Kubilay Kocak from comment #13) Indeed. Here is the log from my 10.1-RELEASE Poudriere jail for the 3.1.9 patch. A commit references this bug: Author: riggs Date: Sun Jul 12 13:05:05 UTC 2015 New revision: 391781 URL: https://svnweb.freebsd.org/changeset/ports/391781 Log: - Update to upstream version 3.1.9 - Add OPTIONs to select the media player used for playback - Add NO_ARCH PR: 199246 Submitted by: tkato432@yahoo.com Reviewed by: jason.unovitch@gmail.com Changes: head/multimedia/gtk-youtube-viewer/Makefile head/multimedia/gtk-youtube-viewer/distinfo head/multimedia/gtk-youtube-viewer/pkg-descr head/multimedia/gtk-youtube-viewer/pkg-plist |
Created attachment 155284 [details] multimedia_gtk-youtube-viewer.diff