Summary: | [PATCH] russian/emkatic: Update to 0.20 | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Andrey Fesenko <andrey> | ||||||||||
Component: | Individual Port(s) | Assignee: | Alexey Dokuchaev <danfe> | ||||||||||
Status: | Closed FIXED | ||||||||||||
Severity: | Affects Only Me | CC: | danfe | ||||||||||
Priority: | --- | Keywords: | easy, patch, patch-ready | ||||||||||
Version: | Latest | ||||||||||||
Hardware: | Any | ||||||||||||
OS: | Any | ||||||||||||
Attachments: |
|
Created attachment 155300 [details]
poudriere build log for 0.20
Created attachment 155346 [details]
Update patch
Changed source code archive, fix typo in a CHANGELOG.txt (fix Update patch)
Thanks for your submission Andrey. Minor nit, if you could sort and group your OPTIONS_DEFINE and OPTIONS_DEFAULT entries, that would be great. Created attachment 155358 [details]
Update patch
Group OPTIONS_DEFINE and OPTIONS_DEFAULT alphabetical
Port definitely needs some love. I'll handle if from now on. Now further patches are probably necessary. Thanks Alexey A commit references this bug: Author: danfe Date: Fri Apr 10 09:25:40 UTC 2015 New revision: 383714 URL: https://svnweb.freebsd.org/changeset/ports/383714 Log: - Update to version 0.20 and install CHANGELOG.txt file - Add missing LCL_UNITS_DIR assignment (otherwise port was not buildable both locally and in tinderbox) - Rename rather vague LCL (Lazarus Component Library) option to GUI as it better reflects its usage and comes with nice default description - Rephrase {GTK2|QT4}_DESC and spell GTK+ and Qt correctly - Sanitize installation target recipe and improve port description text PR: 199260 Changes: head/russian/emkatic/Makefile head/russian/emkatic/distinfo head/russian/emkatic/pkg-descr Committed (with modifications) as of ports r383714, thanks for your submission. By the way, I do not see the need to put in into `russian' category; IMHO `emulators' suits it much better. The mere fact that it only supports Cyrillic user interface does not warrant it. If you would tell me we have a port for a calculator (of any origin or country) emulator, I'd look under `emulators` (notice that emulators for TI and HP calculators already live there). Last but not least, look at the package name: ru-emkatic-0.20. It suggest that there should be master, language-agnostic package emkatic-0.20 (and maybe other xx-emkatic packages), but this is simply not true in this case. Consider moving it to `emulators' at some point (even better, send a patch to upstream so it gets proper English support! ;-). |
Created attachment 155299 [details] Update patch Update to version 0.20 Add DOCS (CHANGELOG.txt - UTF8) Remapping keys added small fixes