Bug 199428
| Summary: | [patch] ports-mgmt/portlint: make sure that first-paragraph things appear in the first paragraph | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Adam Weinberger <adamw> | ||||
| Component: | Individual Port(s) | Assignee: | Joe Marcus Clarke <marcus> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | Keywords: | patch | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(marcus) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Well, then, maybe the list should be put in a variable, so that duplication is not needed. Committed to my CVS repo pending the next release. Thanks! Committed, thanks! |
Created attachment 155566 [details] patch The list of things from the first section (PORTNAME) that gets checked for order (checkorder()) contains things that aren't checked by checkearlier(). The consequence of this is that those items only get checked if they appear in the first section. If they appear elsewhere in the Makefile, portlint doesn't catch it. Joe, I think that the list of items on line 2668 should be the same as the list on line 2307... do I have that right? If my logic is correct there, the attached patch makes those two lists identical.