Bug 199545

Summary:

comms/usbmuxd: fails to build on 11.0 and 10.2

Product:

Ports & Packages

Reporter:

Jan Beich <jbeich>

Component:

Individual Port(s)

Assignee:

Jan Beich <jbeich>

Status:

Closed FIXED

Severity:

Affects Only Me

Flags:

bugzilla: maintainer-feedback? (avilla)

Priority:

---

Version:

Latest

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
autoconf way, v0	none
8.4R amd64 build log	none
11.0C i386 build log	none

Description Jan Beich freebsd_committer

2015-04-19 16:52:27 UTC

Created attachment 155738 [details]
autoconf way, v0

ppoll(2) was added in base r274462 and base r275986 (MFC) which leads to the following build error

  main.c:153:12: error: static declaration of 'ppoll' follows non-static declaration
  static int ppoll(struct pollfd *fds, nfds_t nfds, const struct timespec *timeout, const sigset_t *sigmask)
             ^
  /usr/include/poll.h:114:5: note: previous declaration is here
  int     ppoll(struct pollfd _pfd[], nfds_t _nfds,
          ^
  1 error generated.

https://github.com/libimobiledevice/usbmuxd/pull/36
https://lists.freebsd.org/pipermail/freebsd-pkg-fallout/Week-of-Mon-20150413/230242.html

Comment 1 Jan Beich freebsd_committer

2015-04-19 16:57:27 UTC

Comment on attachment 155738 [details]
autoconf way, v0

The patch would also help get rid of
https://github.com/DragonFlyBSD/DeltaPorts/blob/master/ports/comms/usbmuxd/dragonfly/patch-src_main.c

Comment 2 Jan Beich freebsd_committer

2015-04-19 17:01:47 UTC

Created attachment 155739 [details]
8.4R amd64 build log

Comment 3 Jan Beich freebsd_committer

2015-04-19 17:02:33 UTC

Created attachment 155740 [details]
11.0C i386 build log

Comment 4 commit-hook freebsd_committer

2015-05-05 11:36:59 UTC

A commit references this bug:

Author: jbeich
Date: Tue May  5 11:35:57 UTC 2015
New revision: 385468
URL: https://svnweb.freebsd.org/changeset/ports/385468

Log:
  comms/usbmuxd: unbreak build on 10.2R and 11.0C

  Try to autodetect ppoll(2) instead of hardcoding the list of
  platforms lacking it thus using fallback.

  GitHub:		libimobiledevice/usbmuxd#36
  PR:		199545
  Reported by:	pkg-fallout
  Approved by:	maintainer timeout (2 weeks)

Changes:
  head/comms/usbmuxd/files/
  head/comms/usbmuxd/files/patch-ppoll