Bug 199566

Summary:	lang/polyml: pkg-config output missing libffi dependency
Product:	Ports & Packages	Reporter:	Brooks Davis <brooks>
Component:	Individual Port(s)	Assignee:	Kurt Jaeger <pi>
Status:	Closed FIXED
Severity:	Affects Only Me	CC:	beyert, cs, miwi, pi
Priority:	---	Flags:	beyert: maintainer-feedback+
Version:	Latest
Hardware:	Any
OS:	Any

Description Brooks Davis freebsd_committer

2015-04-20 22:10:14 UTC

"pkg-config --libs polyml" produces:

-L/usr/local/lib -lpolymain -lpolyml -lpthread -lm -lstdc++ -lgcc_s -lgcc

When you use this to link polyml to a program it fails with missing libffi references.  As a workaround you can use "pkg-config --libs polyml libffi" which produces:

-lpolymain -lpolyml -lpthread -lm -lstdc++ -lgcc_s -lgcc -L/usr/local/lib -lffi

Comment 1 Timothy Beyer 2015-04-21 03:01:58 UTC

Thanks for the heads up.

I haven't tested Poly/ML to build Isabelle in quite a while, so it might need some more testing.  I'll check to see if some small SML programs that I wrote compile properly using Poly/ML.

Most of the large SML programs that I use support MLTon or SML/NJ (eg. Ur/Web), so I'll need to find out which ones support Poly/ML, and verify with that respective program.

Comment 2 Carlo Strub freebsd_committer

2015-09-15 21:49:50 UTC

Any news on this bug?

Comment 3 Timothy Beyer 2015-09-16 08:14:32 UTC

I haven't gotten a chance to test it in depth yet, I'll try to get to it soon, as it looks fairly easy to address.

Comment 4 Martin Wilke freebsd_committer

2015-12-24 20:51:43 UTC

Hi,

any update on this?

Comment 5 Timothy Beyer 2016-04-15 02:32:57 UTC

It turns out that a later version of polyml corrected this issue.  When I did some work on a submitted update to polyml, now I get the proper output:

> hypercube# pkg-config --libs polyml
-L/usr/local/lib -lpolymain -lpolyml -lpthread -lffi  -lm -lgcc_s -lgcc

Notice that -lffi is included, as it should.

See issue #208783 for more details.

My apologies for taking so long to get to this issue.

Regards,
Tim

Comment 6 commit-hook freebsd_committer

2016-04-15 19:58:13 UTC

A commit references this bug:

Author: pi
Date: Fri Apr 15 19:58:04 UTC 2016
New revision: 413374
URL: https://svnweb.freebsd.org/changeset/ports/413374

Log:
  lang/polyml: 5.5.2 -> 5.6

  Changes:
  - New foreign-function interface (Foreign structure).
  - Reimplemented debugger so that code with debugging enabled is much faster.
  - Improved support for Poly/ML on native Windows.
  - Support for MIPS and 64-bit ARM processors through the byte-code interpreter.
  - Various bug fixes.

  PR:		208783, 199566
  Submitted by:	Phil Eaton <philneaton95@gmail.com>, brooks
  Approved by:	Timothy Beyer <beyert@cs.ucr.edu> (maintainer)

Changes:
  head/lang/polyml/Makefile
  head/lang/polyml/distinfo
  head/lang/polyml/pkg-plist

Comment 7 Kurt Jaeger freebsd_committer

2016-04-15 19:59:11 UTC

The update is now committed, as submitted in 208783.