Bug 199609

Summary: [PATCH] devel/vera++: Update to 1.3.0
Product: Ports & Packages Reporter: lightside <lightside>
Component: Individual Port(s)Assignee: Thomas Zander <riggs>
Status: Closed FIXED    
Severity: Affects Some People CC: cristianorolim, riggs
Priority: --- Keywords: patch, patch-ready
Version: LatestFlags: cristianorolim: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Proposed patch (since 344780 revision)
none
The poudriere testport log (FreeBSD 10 amd64, with default options, i.e. all enabled)
none
The poudriere testport log (FreeBSD 10 amd64, with all options disabled)
none
Proposed patch (since 344780 revision)
koobs: maintainer-approval+
The poudriere testport log (FreeBSD 10 amd64, with default options, i.e. all enabled)
none
The poudriere testport log (FreeBSD 10 amd64, with all options disabled)
none
The poudriere testport log (FreeBSD 10 amd64, with LUA=on, PYTHON=off)
none
The poudriere testport log (FreeBSD 10 amd64, with LUA=off, PYTHON=on) none

Description lightside 2015-04-22 12:49:03 UTC
Created attachment 155847 [details]
Proposed patch (since 344780 revision)

Patch to update devel/vera++ port from 1.2.1 to 1.3.0 version.

Look following links for changes:
https://bitbucket.org/verateam/vera/wiki/Changes

- Add license information
- Add DOCS option
- Add LUA and PYTHON options and enable them by default, as developers did
- Replace tk with tcl in USES
- Convert to dynamic plist
Comment 1 lightside 2015-04-22 12:50:32 UTC
Created attachment 155848 [details]
The poudriere testport log (FreeBSD 10 amd64, with default options, i.e. all enabled)
Comment 2 lightside 2015-04-22 12:51:20 UTC
Created attachment 155849 [details]
The poudriere testport log (FreeBSD 10 amd64, with all options disabled)
Comment 3 lightside 2015-04-23 05:50:36 UTC
Created attachment 155891 [details]
Proposed patch (since 344780 revision)

> - Replace tk with tcl in USES

Returned tk in USES (while this not required), as committer did in ports r344780.

Reorganized dependencies for PYTHON option.
Comment 4 lightside 2015-04-23 05:51:54 UTC
Created attachment 155892 [details]
The poudriere testport log (FreeBSD 10 amd64, with default options, i.e. all enabled)
Comment 5 lightside 2015-04-23 05:52:20 UTC
Created attachment 155893 [details]
The poudriere testport log (FreeBSD 10 amd64, with all options disabled)
Comment 6 lightside 2015-04-23 05:53:15 UTC
Created attachment 155894 [details]
The poudriere testport log (FreeBSD 10 amd64, with LUA=on, PYTHON=off)
Comment 7 lightside 2015-04-23 05:53:57 UTC
Created attachment 155895 [details]
The poudriere testport log (FreeBSD 10 amd64, with LUA=off, PYTHON=on)
Comment 8 lightside 2015-04-23 05:57:54 UTC
Added maintainer email address to CC list, because automatic method (in moment of PR creation) didn't work for some reason.
Comment 9 cristianorolim 2015-04-23 20:39:51 UTC
Fine, I approve the patch.

Thanks!
Comment 10 commit-hook freebsd_committer freebsd_triage 2015-05-01 18:47:44 UTC
A commit references this bug:

Author: riggs
Date: Fri May  1 18:46:54 UTC 2015
New revision: 385138
URL: https://svnweb.freebsd.org/changeset/ports/385138

Log:
  - Update to upstream version 1.3.0
  - Retire pkg-plist in favor of PLIST_FILES entries

  PR:		199609
  Submitted by:	lightside@gmx.com
  Reviewed by:	cristianorolim@outlook.com (maintainer)

Changes:
  head/devel/vera++/Makefile
  head/devel/vera++/distinfo
  head/devel/vera++/pkg-plist
Comment 11 Thomas Zander freebsd_committer freebsd_triage 2015-05-01 18:49:52 UTC
Exemplary report! Thanks!