Bug 199613
| Summary: | [MAINTAINER] games/wtf: Update to 20150421 | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Nikolai Lifanov <lifanov> | ||||||||||||||
| Component: | Individual Port(s) | Assignee: | Adam Weinberger <adamw> | ||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||
| Severity: | Affects Some People | CC: | adamw | ||||||||||||||
| Priority: | --- | Keywords: | patch, patch-ready | ||||||||||||||
| Version: | Latest | ||||||||||||||||
| Hardware: | Any | ||||||||||||||||
| OS: | Any | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
Created attachment 155859 [details]
poudriere testport log
Please receive Poudriere testport log.
Created attachment 155863 [details]
games/wtf 20150416 -> 20150422
Bump snapshot by a day. This one contains a doc fix:
PR/49850: Nikolai Lifanov: Document acronyms-o
Created attachment 155873 [details]
games/wtf 20150416 -> 20150422
I forgot to include bsd.port.options.mk in last patch.
Created attachment 155943 [details]
games/wtf 20150416 -> 20150424
Update the patch to the latest snapshot.
Created attachment 155944 [details]
poudriere testport log
Re-run poudriere testport the log with the latest patch.
I'm not sure OFFENSIVE should be an OPTIONS_DEFAULT (not a personal opinion). You are the maintainer, please consider the implications and advise. My reasoning is, all historic versions of this port had offensive acronyms included in the main acronyms database already and in the new version the user is shielded from them with the new "-o" flag. Also, upstream includes them by default. But it's nice to give people the OPTION to turn this off now that there is a mechanism for doing so. Thanks for the feedback Nikolai A commit references this bug: Author: adamw Date: Fri Apr 24 20:37:57 UTC 2015 New revision: 384685 URL: https://svnweb.freebsd.org/changeset/ports/384685 Log: Update to 20150424. Introduce an OPTION that controls whether to install offensive (explicit) acronyms. It is enabled by default, but the actual wtf(6) app will not provide offensive answers without the -o switch. PR: 199613 Submitted by: maintainer (Nikolai Lifanov) Changes: head/games/wtf/Makefile head/games/wtf/distinfo head/games/wtf/pkg-plist Nikolai, I agree with your logic here. Committing as submitted (with a spacing fix). |
Created attachment 155858 [details] games/wtf 20150416 -> 20150421 This update chases the upstream NetBSD split of acronyms database into offensive and non-offensive versions. The wtf utility gets a "-o" flag, which is now necessary for invocations like: $ wtf wtf wtf: I don't know what `wtf' means! $ wtf -o wtf ....output.... The port received an option to install the offensive acronym database, selected by default, and installs a "fake" (empty) offensive acronym database if the option is deselected.