Bug 199662

Summary: [PATCH] devel/rubygem-rugged update to 0.21.4
Product: Ports & Packages Reporter: Torsten Zühlsdorff <ports>
Component: Individual Port(s)Assignee: Koop Mast <kwm>
Status: Closed Overcome By Events    
Severity: Affects Many People CC: mmoll, ports
Priority: --- Keywords: patch
Version: LatestFlags: bugzilla: maintainer-feedback? (ruby)
Hardware: Any   
OS: Any   
Bug Depends on: 196176    
Bug Blocks: 199663    
Attachments:
Description Flags
patch against devel/rubygem-rugged
none
patch against devel/rubygem-rugged v2
none
patch against devel/rubygem-rugged v3 none

Description Torsten Zühlsdorff 2015-04-24 15:20:49 UTC
Created attachment 155946 [details]
patch against devel/rubygem-rugged

While working at a port for gitlab, i figured out, that an update for this gem is needed. Patch attached :)
Comment 1 Michael Fausten 2015-04-25 11:09:20 UTC
Hi all,

I think in the distinfo file is a little error: the port version is incorrect. instead of this:

SHA256 (rubygem/rugged-0.21.0.gem) = 9be7a845ec402e7aa713af561a1dba47993fed3fd37376898d8067c955faa4a7
SIZE (rubygem/rugged-0.21.0.gem) = 926208

it should be:

SHA256 (rubygem/rugged-0.21.4.gem) = 9be7a845ec402e7aa713af561a1dba47993fed3fd37376898d8067c955faa4a7
SIZE (rubygem/rugged-0.21.4.gem) = 926208

Best regards
Comment 2 Torsten Zühlsdorff 2015-04-27 08:51:27 UTC
Created attachment 156034 [details]
patch against devel/rubygem-rugged v2

Michael is right; fix version attached; poudriere will follow
Comment 3 Torsten Zühlsdorff 2015-04-27 09:03:16 UTC
After cleaning my test-jail i've noticed, that this patch has a dependencies. I will write another patch, before this one can be committed. Sorry. -.-
Comment 4 Torsten Zühlsdorff 2015-04-27 10:58:55 UTC
A Patch and Bugreport already exists. Add a dependency for this.
Comment 5 Torsten Zühlsdorff 2015-05-05 13:40:22 UTC
Created attachment 156377 [details]
patch against devel/rubygem-rugged v3

While testing i figured out, that it is very hard to keep this port in sync with devel/libgit2 and its derivates.
Also the port comes with a bundled libgit2.
Therefore i changed the patch, so the user can choose if the bundled-lib should be installed or devel/libgit2 should be used.
Comment 6 Michael Moll freebsd_committer freebsd_triage 2015-05-06 21:45:47 UTC
kwm is working on it in https://reviews.freebsd.org/D2468
Comment 7 Torsten Zühlsdorff 2015-05-07 07:13:43 UTC
That's fine :)

But i'm missing the added option to choose between libgit2 provided by the system and bundled libgit. This would be very nice to have. :)
Comment 8 Michael Moll freebsd_committer freebsd_triage 2015-05-11 21:23:19 UTC
devel/rubygem-rugged was updated to 0.22.1b1 in r386103