Bug 199664

Summary:	security/gnomint patch for FILE_UNSET+=NLS
Product:	Ports & Packages	Reporter:	Beeblebrox <zaphod>
Component:	Individual Port(s)	Assignee:	Tijl Coosemans <tijl>
Status:	Closed FIXED
Severity:	Affects Some People	CC:	kevinz5000
Priority:	---	Flags:	kevinz5000: maintainer-feedback+
Version:	Latest
Hardware:	Any
OS:	Any

Description Beeblebrox 2015-04-24 15:23:19 UTC

Port fails to build with "OPTIONS_FILE_UNSET+=NLS". The error is the usual "GNU gettext tools not found" problem.

Patch security/gnomint:
@ -32 +32 @
- NLS_USES=	    gettext
+ NLS_USES=	    gettext-runtime

Comment 1 Beeblebrox 2015-04-24 15:53:57 UTC

Please disregard.
Patch does not work in poudriere, where this type of problem occurs.

Comment 2 Kevin Zheng 2015-04-25 03:01:58 UTC

Thanks for the report. I'm traveling right now, but I'll take a closer look as soon as I get back.

Comment 3 Beeblebrox 2015-04-25 03:24:53 UTC

Here's the correct patch, courtesy of Tijl Coosemans.
Tested in poudriere_11-current_amd64.

-------------------------
security/gnomint/Makefile
@@ -23 +23 @@
-USES=		gmake perl5 pkgconfig readline
+USES=		gmake perl5 pkgconfig readline gettext-tools

@@ -32 +32 @@
-NLS_USES=		gettext
+NLS_USES=		gettext-runtime

Comment 4 Kevin Zheng 2015-04-25 22:25:35 UTC

I haven't had a chance to test with my local poudriere, but the patch looks correct and I don't see a problem if it works (better than it does now) in another poudriere. Go ahead and commit!

Comment 5 commit-hook freebsd_committer

2015-04-26 09:51:53 UTC

A commit references this bug:

Author: tijl
Date: Sun Apr 26 09:51:14 UTC 2015
New revision: 384770
URL: https://svnweb.freebsd.org/changeset/ports/384770

Log:
  - Add USES=gettext-tools to fix build when NLS option is off [1]
  - Remove dependency on textproc/intltool because it's implied by
    USE_GNOME=gtk20

  PR:		199664 [1]
  Approved by:	Kevin Zheng <kevinz5000@gmail.com> (maintainer) [1]

Changes:
  head/security/gnomint/Makefile