Bug 199795

Summary: [patch] update databases/sqlitebrowser to 3.6.0
Product: Ports & Packages Reporter: sf(jungleboogie) <Jungleboogie0>
Component: Individual Port(s)Assignee: Frederic Culot <culot>
Status: Closed FIXED    
Severity: Affects Some People CC: culot, lbartoletti
Priority: --- Keywords: patch
Version: LatestFlags: lbartoletti: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Updating to latest version, 3.6.0
none
Update to sqlitebrowser 3.6.0 none

Description sf(jungleboogie) 2015-04-30 04:10:44 UTC
Created attachment 156128 [details]
Updating to latest version, 3.6.0

sqlitebrowser was released on 27 April, 2015.
Comment 1 Frederic Culot freebsd_committer freebsd_triage 2015-04-30 12:33:51 UTC
Thanks for submitting this patch, however it is not complete: the patch is missing an update to the distinfo file and it is still using the obsolete GH_COMMIT macro.

Could you please have a look at those issues?

Thanks,
Frederic
Comment 2 Frederic Culot freebsd_committer freebsd_triage 2015-04-30 12:35:47 UTC
Loic, as the maintainer could you please check and approve this patch when corrected?

Thanks,
Frederic
Comment 3 sf(jungleboogie) 2015-04-30 19:47:34 UTC
(In reply to Frederic Culot from comment #1)

Hi Frederic,

Sorry about the incomplete patch and the legacy style. 

I'll defer to the maintainer to update the port and learn from my mistakes on proving the current GH_COMMIT macro.

thanks,
sf
Comment 4 Loïc Bartoletti freebsd_committer freebsd_triage 2015-05-09 07:26:26 UTC
Created attachment 156535 [details]
Update to sqlitebrowser 3.6.0
Comment 5 Loïc Bartoletti freebsd_committer freebsd_triage 2015-05-09 07:27:33 UTC
Here the patch and the test with poudriere :

Poudriere:
http://download.tuxfamily.org/bartcoding/ports/sqlitebrowser/
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-05-11 13:01:34 UTC
A commit references this bug:

Author: culot
Date: Mon May 11 13:00:53 UTC 2015
New revision: 386078
URL: https://svnweb.freebsd.org/changeset/ports/386078

Log:
  - Update to 3.6.0

  PR:		199795
  Submitted by:	Jungleboogie0@gmail.com, coder@tuxfamily.org
  Approved by:	coder@tuxfamily.org (maintainer)
  Changes:	https://github.com/sqlitebrowser/sqlitebrowser/releases/tag/v3.6.0

Changes:
  head/databases/sqlitebrowser/Makefile
  head/databases/sqlitebrowser/distinfo
  head/databases/sqlitebrowser/files/patch-src-PreferencesDialog.cpp
  head/databases/sqlitebrowser/pkg-plist