Bug 199939
| Summary: | books/porters-handbook: typo in USE_GITHUB + DISTVERSIONPREFIX example | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Documentation | Reporter: | Jan Beich <jbeich> | ||||
| Component: | Books & Articles | Assignee: | freebsd-doc (Nobody) <doc> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | brueffer, mat | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
A commit references this bug: Author: brueffer Date: Mon Jun 29 14:06:57 UTC 2015 New revision: 46890 URL: https://svnweb.freebsd.org/changeset/doc/46890 Log: USE_GITHUB doesn't touch PORTREVISION at all. What the author meant is probably PORTVERSION. However, using DISTVERSION is more correct because it also fixes unusual versioning (1.5-alpha, 1_2, etc). PR: 199939 Submitted by: jbeich Reviewed by: mat (aka "the author") Changes: head/en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml Fixed, thanks! |
Created attachment 156352 [details] v0 USE_GITHUB doesn't touch PORTREVISION at all. What the author meant is probably PORTVERSION. However, using DISTVERSION is more correct because it also fixes unusual versioning (1.5-alpha, 1_2, etc).