Bug 199979

Summary:	[exp-run] with libgomp removed from base (if no GCC)
Product:	Ports & Packages	Reporter:	Ed Maste <emaste>
Component:	Ports Framework	Assignee:	Ed Maste <emaste>
Status:	Closed FIXED
Severity:	Affects Only Me	CC:	portmgr, stephen
Priority:	---
Version:	Latest
Hardware:	Any
OS:	Any
See Also:	https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200203
Bug Depends on:	200192
Bug Blocks:

Description Ed Maste freebsd_committer

2015-05-06 00:52:06 UTC

review D2459: Build libgomp only if we're also building base system GCC

Clang's OpenMP support will emit Intel OpenMP API library calls, and will therefore require libiomp (or whatever name is settled on). An up-to-date version of libgomp is included in ports or pkg GCC. Thus, there is no reason to build base libgomp without base system GCC.

Review: https://reviews.freebsd.org/D2459
Raw diff: https://reviews.freebsd.org/file/data/eqpuxp62q3doefdf6mgb/PHID-FILE-zczkjoqqecabosrsmbwy/D2459.diff

Comment 1 Antoine Brodin freebsd_committer

2015-05-06 09:17:28 UTC

Take for exp-run

Comment 2 Antoine Brodin freebsd_committer

2015-05-07 18:20:40 UTC

Exp-run results:

http://pb2.nyi.freebsd.org/jail.html?mastername=headi386D2459-default
http://package18.nyi.freebsd.org/jail.html?mastername=headamd64D2459-default

1 new failure:

+ {"origin"=>"math/octave-forge-nurbs", "pkgname"=>"octave-forge-nurbs-1.3.9", "phase"=>"build", "errortype"=>"missing_header"}

Failure log:

http://pb2.nyi.freebsd.org/data/headi386D2459-default/2015-05-07_16h50m58s/logs/errors/octave-forge-nurbs-1.3.9.log
http://package18.nyi.freebsd.org/data/headamd64D2459-default/2015-05-07_12h09m16s/logs/errors/octave-forge-nurbs-1.3.9.log

I have put the maintainer of octave-forge-nurbs in cc:

Comment 3 commit-hook freebsd_committer

2015-05-15 14:22:56 UTC

A commit references this bug:

Author: emaste
Date: Fri May 15 14:22:34 UTC 2015
New revision: 282973
URL: https://svnweb.freebsd.org/changeset/base/282973

Log:
  Build libgomp only if we're also building base system GCC

  Clang's OpenMP support will emit Intel OpenMP API library calls,
  and will therefore require libiomp (or whatever name is settled on).
  An up-to-date version of libgomp is included in ports or pkg GCC.
  Thus, there is no reason to build base libgomp without base system GCC.

  PR:		199979 (exp-run)
  Reviewed by:	pfg
  Relnotes:	Yes
  Sponsored by:	The FreeBSD Foundation
  Differential Revision: https://reviews.freebsd.org/D2459

Changes:
  head/gnu/lib/Makefile
  head/tools/build/mk/OptionalObsoleteFiles.inc