Bug 200005
| Summary: | irc/znc: rc script assumes a user that is not created with package | ||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Josh Galvez <josh+freebsd> | ||||||||||||||||||||||||||||||||
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||||||||||||||||||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||||||||||||||||||||
| Severity: | Affects Many People | CC: | amdmi3, dbaio, koobs | ||||||||||||||||||||||||||||||||
| Priority: | --- | Keywords: | easy | ||||||||||||||||||||||||||||||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(jase) amdmi3: merge-quarterly+ |
||||||||||||||||||||||||||||||||
| Hardware: | Any | ||||||||||||||||||||||||||||||||||
| OS: | Any | ||||||||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||||||||
|
Description
Josh Galvez
2015-05-06 17:58:18 UTC
Maintainer timeout (> 1 year). Open to take. Created attachment 174356 [details]
znc_user_group.patch
patch attached to fix this:
- znc user/group are now being created on the system.
- move pkg-message to files directory
- remove pre-configure sections to fix building on head.
- replace OPENSSL_USE to USES=ssl
testport:
poudriere: i386, 10.3 (OK)
poudriere: amd64, 10.3 (OK)
poudriere: i386, 9.3 (OK)
poudriere: amd64, 9.3 (OK)
poudriere: i386, 12 (OK)
poudriere: amd64, 12 (OK)
there isn't new warnings on portlint:
[~/FreeBSD/ports/irc/znc]$ portlint -C
WARN: Makefile: [63]: use ${VARIABLE}, instead of $(VARIABLE).
WARN: Makefile: [46]: possible direct use of command "perl" found. use ${PERL} instead.
0 fatal errors and 2 warnings found.
Wonderful Danilo, thank you. Created attachment 174668 [details]
znc_user_group_v2.patch
I've updated the patch, there is an update upstream.
CCing @amdmi3 could you take a look, please ?
- Create znc user/group
- Move pkg-message to files directory
- Insert an information about znc user/group on pkg-message
- Bump PORTREVISION
@Danilo, Please confirm QA on the updated patch (attachment 174668 [details]) ?
Created attachment 174679 [details]
poudriere - 93-amd64 - znc-1.6.3_3.log
Created attachment 174680 [details] poudriere - 12-amd64 - znc-1.6.3_3.log Sure. Same warnings on portlint: [~/FreeBSD/ports/irc/znc]$ portlint -C WARN: Makefile: [74]: use ${VARIABLE}, instead of $(VARIABLE). WARN: Makefile: [48]: possible direct use of command "perl" found. use ${PERL} instead. 0 fatal errors and 2 warnings found. Poudriere testport: poudriere: i386, 10.3 (OK) poudriere: amd64, 10.3 (OK) poudriere: i386, 9.3 (OK) poudriere: amd64, 9.3 (OK) poudriere: i386, 12 (OK) poudriere: amd64, 12 (OK) This and attachment 174679 [details] as poudriere testport examples. I am an user of znc and the attachment 174668 [details] worked fine. Thank you. In this moment irc/znc has no maintainer. ports r422375 I could take this maintainer'ship, I am a daily user of irc/znc. Thank you. Created attachment 175572 [details]
znc_user_group_v3.patch
Hi.
Port irc/znc was updated.
Updating outdated patch.
- Create znc user/group
- Set permissions properly on ETCDIR
- Move pkg-message to files directory
- Insert an information about znc user/group on pkg-message
- Update distinfo with TIMESTAMP
- Bump PORTREVISION
- Take maintainer'ship
[QA]
Poudriere testport:
poudriere: i386, 9.3 (OK)
poudriere: amd64, 9.3 (OK)
poudriere: i386, 10.3 (OK)
poudriere: amd64, 10.3 (OK)
poudriere: i386, 12 (OK)
poudriere: amd64, 12 (OK)
Same warnings on portlint:
[~/FreeBSD/ports/irc/znc]$ portlint -C
WARN: Makefile: [73]: use ${VARIABLE}, instead of $(VARIABLE).
WARN: Makefile: [47]: possible direct use of command "perl" found. use ${PERL} instead.
0 fatal errors and 2 warnings found.
I will attach some poudriere logs for the record.
Created attachment 175573 [details]
poudriere - 93-amd64 - znc-1.6.3_4.log
Created attachment 175574 [details]
poudriere - 103-amd64 - znc-1.6.3_4.log
Created attachment 175575 [details]
poudriere - 12-amd64 - znc-1.6.3_4.log
Created attachment 175658 [details] znc_user_group_v4_svn.patch Updating outdated patch by ports r423687 - Create znc user/group - Set permissions properly on ETCDIR - Move pkg-message to files directory - Insert an information about znc user/group on pkg-message - Update distinfo with TIMESTAMP - Bump PORTREVISION - Take maintainer'ship [QA] Poudriere testport: poudriere: i386, 9.3 (OK) poudriere: amd64, 9.3 (OK) poudriere: i386, 10.3 (OK) poudriere: amd64, 10.3 (OK) poudriere: i386, 11 (OK) poudriere: amd64, 11 (OK) poudriere: i386, 12 (OK) poudriere: amd64, 12 (OK) Same warnings on portlint: [~/FreeBSD/ports/irc/znc]$ portlint -C WARN: Makefile: [73]: use ${VARIABLE}, instead of $(VARIABLE). WARN: Makefile: [47]: possible direct use of command "perl" found. use ${PERL} instead. 0 fatal errors and 2 warnings found. Created attachment 175659 [details]
znc_user_group_v4_patch-compatible.patch
Created attachment 175997 [details]
znc_user_group_v4_svn.patch
missing GIDs/UIDs
Created attachment 175998 [details]
znc_user_group_v4_patch-compatible.patch
missing GIDs/UIDs
Created attachment 176055 [details] znc_user_group_v5_svn.patch Port updated on ports r424427 Created attachment 176056 [details] znc_user_group_v5_patch-compatible.patch Port updated on ports r424427 Created attachment 176061 [details]
znc_user_group--patch-compatible.patch
A commit references this bug: Author: amdmi3 Date: Wed Nov 23 11:43:14 UTC 2016 New revision: 426896 URL: https://svnweb.freebsd.org/changeset/ports/426896 Log: - Create znc user/group - Set permissions properly on ETCDIR - Add an information on znc user/group to pkg-message - Pass maintainership to dbaio PR: 200005 Submitted by: josh+freebsd@zevlag.com, dbaio@bsd.com.br Changes: head/GIDs head/UIDs head/irc/znc/Makefile head/irc/znc/distinfo head/irc/znc/files/pkg-message.in head/irc/znc/pkg-message head/irc/znc/pkg-plist Re-open for MFH A commit references this bug: Author: amdmi3 Date: Thu Nov 24 14:55:01 UTC 2016 New revision: 427021 URL: https://svnweb.freebsd.org/changeset/ports/427021 Log: MFH: r426896 - Create znc user/group - Set permissions properly on ETCDIR - Add an information on znc user/group to pkg-message - Pass maintainership to dbaio PR: 200005 Submitted by: josh+freebsd@zevlag.com, dbaio@bsd.com.br Approved by: ports-secteam (feld) Changes: _U branches/2016Q4/ branches/2016Q4/GIDs branches/2016Q4/UIDs branches/2016Q4/irc/znc/Makefile branches/2016Q4/irc/znc/distinfo branches/2016Q4/irc/znc/files/pkg-message.in branches/2016Q4/irc/znc/pkg-message branches/2016Q4/irc/znc/pkg-plist |
