Bug 200050

Summary: dns/credns: create /var directories from plist
Product: Ports & Packages Reporter: Dmitry Marakasov <amdmi3>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Only Me CC: jaap
Priority: --- Flags: bugzilla: maintainer-feedback? (jaap)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch
none
Slightly improved patch jaap: maintainer-approval+

Description Dmitry Marakasov freebsd_committer freebsd_triage 2015-05-08 10:58:05 UTC
Created attachment 156505 [details]
Patch

- Currently credns creates /var directories from rc.d script, so there's no way for package system to track them. Instead, create them from plist.
- Strip binaries
- Add LICENSE_FILE
Comment 1 Jaap Akkerhuis 2015-05-08 15:57:49 UTC
Created attachment 156512 [details]
Slightly improved patch

I tested the proposed patch with poudriere and it needed a small adjustment.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-05-09 02:04:18 UTC
A commit references this bug:

Author: amdmi3
Date: Sat May  9 02:04:07 UTC 2015
New revision: 385853
URL: https://svnweb.freebsd.org/changeset/ports/385853

Log:
  - Create /var directories from plist, not rc.d script
  - Strip binaries
  - Add LICENSE_FILE

  PR:		200050
  Submitted by:	amdmi3
  Approved by:	jaap@NLnetLabs.nl (maintainer)

Changes:
  head/dns/credns/Makefile
  head/dns/credns/files/credns.in
  head/dns/credns/pkg-plist
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2015-05-09 02:05:24 UTC
You should probably update your poudriere portstree: the ability to omit some keyword argument appeared not long ago, your portstree may be older than this point. Anyway committed your version, thanks!