Bug 200142

Summary: [exp-run] [patch] Make liblzma use libmd
Product: Ports & Packages Reporter: Xin LI <delphij>
Component: Ports FrameworkAssignee: Port Management Team <portmgr>
Status: Open ---    
Severity: Affects Many People CC: bapt, emaste, portmgr
Priority: --- Keywords: patch
Version: LatestFlags: delphij: exp-run?
Hardware: Any   
OS: Any   
Description Flags
Revision 282775.
New patch against -HEAD
Updated patch against -HEAD
Patch for ports-mgmt/pkg to fix pkg-static build
delphij: maintainer-approval? (portmgr)
Patch for ports-mgmt/pkg-devel to fix liblzma.pc usage delphij: maintainer-approval? (portmgr)

Description Xin LI freebsd_committer 2015-05-12 05:45:12 UTC
Created attachment 156677 [details]
Revision 282775.

I'd like to request an exp-run with the attached patch so that we can find out how many ports would be affected by it (i.e. linking against liblzma statically).
Comment 1 Xin LI freebsd_committer 2015-05-12 05:45:33 UTC
Assign to portmgr@ for exp-run.
Comment 3 Mathieu Arnold freebsd_committer 2015-06-14 03:19:02 UTC
exp-run ran, assign back to submitter.
Comment 4 Ed Maste freebsd_committer 2018-04-15 00:29:20 UTC
What's next here?
Comment 5 Xin LI freebsd_committer 2020-05-14 21:38:55 UTC
Created attachment 214505 [details]
New patch against -HEAD
Comment 6 Xin LI freebsd_committer 2020-05-14 21:41:55 UTC

May I request for a new exp-run just in case this would have broke something?  The new patch is available at https://reviews.freebsd.org/D24805 and attached for your convenience.
Comment 7 Xin LI freebsd_committer 2020-05-22 22:20:59 UTC
Comment 8 Xin LI freebsd_committer 2020-05-23 10:00:34 UTC
Created attachment 214775 [details]
Updated patch against -HEAD
Comment 9 Xin LI freebsd_committer 2020-05-23 10:02:35 UTC
Created attachment 214776 [details]
Patch for ports-mgmt/pkg to fix pkg-static build
Comment 10 Antoine Brodin freebsd_committer 2020-05-23 18:33:17 UTC
(In reply to Xin LI from comment #9)
so it was broken?

I don't think that such change that break even pkg are welcome..
Comment 11 Xin LI freebsd_committer 2020-05-23 18:41:53 UTC
(In reply to Antoine Brodin from comment #10)
ports-mgmt/pkg fails to use pkg-config provided linker flags when building static binary because it hardcoded the library list by default, but the dynamically linked binaries are fine (rtld would correctly load libmd).
Comment 12 Antoine Brodin freebsd_committer 2020-05-23 18:43:37 UTC
And I am not sure that removing symbols from Symbol.map is allowed.
Comment 13 Xin LI freebsd_committer 2020-05-23 18:53:02 UTC
(In reply to Antoine Brodin from comment #12)
These are private symbols, removal of private symbols are generally considered as acceptable and we do remove them all the times (r359930, r359460, r341509 are most recent ones for libc).

The removed symbols were never defined in the public headers anyway.
Comment 15 Xin LI freebsd_committer 2020-05-29 16:49:25 UTC
Created attachment 215029 [details]
Patch for ports-mgmt/pkg-devel to fix liblzma.pc usage

Thanks, here is the fix for the build issue