Bug 200232

Summary: net/mediatomb: fails to build on 10.1/amd64
Product: Ports & Packages Reporter: Maxim Filimonov <che>
Component: Individual Port(s)Assignee: Tijl Coosemans <tijl>
Status: Closed FIXED    
Severity: Affects Only Me CC: leo, tijl
Priority: --- Flags: bugzilla: maintainer-feedback? (leo)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
poudriere log
none
patch none

Description Maxim Filimonov 2015-05-15 23:05:52 UTC
Created attachment 156813 [details]
poudriere log

The mentioned port fails to build. Yes, it was marked broken, but AFAICS, it was marked broken for failing to configure, not failing to build. The problem is right here:

c++ -DHAVE_CONFIG_H -I. -I.. -I../tombupnp/upnp/inc   -DLIBICONV_PLUG -I../src  -I../tombupnp/ixml/inc  -I../tombupnp/threadutil/inc  -I../tombupnp/upnp/inc  -I..  -I/usr/local/include  -I/usr/local/include/mysql -pipe  -fstack-protector -fno-strict-aliasing  -g -fno-omit-frame-pointer -fno-strict-aliasing  -I/usr/local/include  -I/usr/local/include/taglib          -I/usr/local/include    -D_THREAD_SAFE      -I/usr/local/include  -I/usr/local/include  -I/usr/local/include     -O2 -pipe -DLIBICONV_PLUG -fstack-protector -fno-strict-aliasing  -DLIBICONV_PLUG -MT libmediatomb_a-string_converter.o -MD -MP -MF .deps/libmediatomb_a-string_converter.Tpo -c -o libmediatomb_a-string_converter.o `test -f '../src/string_converter.cc' || echo './'`../src/string_converter.cc
../src/string_converter.cc:134:11: error: no matching function for call to 'iconv'
    ret = iconv(cd, (const char**)input_ptr, &input_bytes,
          ^~~~~
/usr/local/include/iconv.h:85:15: note: candidate function not viable: no known conversion from 'const char **' to 'char **' for 2nd argument
extern size_t iconv (iconv_t cd,  char* * inbuf, size_t *inbytesleft, char* * outbuf, size_t *outbytesleft);
              ^
1 error generated.
*** Error code 1


The full poudriere log can be found attached to this bug.
Comment 1 Maxim Filimonov 2015-05-15 23:07:22 UTC
This doesn't seem to be the same as described in #198436.
Comment 2 Jan Beich freebsd_committer freebsd_triage 2015-05-16 02:38:50 UTC
Tijl, do you think it's related in ports r384038 ? The port was already marked BROKEN thus skipped during exp-runs in bug 199099.
Comment 3 Tijl Coosemans freebsd_committer freebsd_triage 2015-05-16 12:50:20 UTC
Created attachment 156823 [details]
patch

Try this patch.
Comment 4 Maxim Filimonov 2015-05-16 13:21:46 UTC
It built after applying the patch. Thank you so much!
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-05-16 13:58:10 UTC
A commit references this bug:

Author: tijl
Date: Sat May 16 13:57:11 UTC 2015
New revision: 386547
URL: https://svnweb.freebsd.org/changeset/ports/386547

Log:
  Fix iconv related build problem.  The port is still marked BROKEN.

  PR:		200232

Changes:
  head/net/mediatomb/Makefile