Summary: | [PATCH] benchmarks/fhourstones: Update MASTER_SITES | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | tkato432 | ||||
Component: | Individual Port(s) | Assignee: | John Marino <marino> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | Keywords: | patch | ||||
Priority: | --- | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
I will take this but I already see some changes in the patch that need to be reverted. A commit references this bug: Author: marino Date: Tue May 19 08:37:44 UTC 2015 New revision: 386748 URL: https://svnweb.freebsd.org/changeset/ports/386748 Log: benchmarks/fhourstones: New MASTER_SITES to unbreak, move executable This port was broken due to being unfetchable. While finding a new source location, switch the executable from lib/fhourstones to libexec/fhourstones. Also, use "sed" and "echo" to eliminate the need for patches. Some changes were made to the submitted patch by me, but they were minor. PR: 200293 Submitted by: Ports Fury Changes: head/benchmarks/fhourstones/Makefile head/benchmarks/fhourstones/files/ head/benchmarks/fhourstones/pkg-descr The main things I changed: 1) I simplified the creation of bin/fhourstones. We didn't need the blank line inserted, nor do we need to use "echo -n" to create the file (">" works fine) 2) I removed the compound cd / install commands. Several committers have asked that all changes like this be blocked so you should stop doing this because it just adds effort for us. 3) I removed the %% format in PLIST_FILES. Please either use make variables or just spell it out. This is not an issue because PLIST_FILES by design must only be 6 lines long at the minimum (otherwise pkg-plist should be used) |
Created attachment 156893 [details] benchmarks_fhourstones.diff