Summary: | [maintainer] finance/electrum: Upgrade to 2.2 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | kyuupichan | ||||||||
Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||||||
Status: | Closed Not Accepted | ||||||||||
Severity: | Affects Only Me | CC: | amdmi3 | ||||||||
Priority: | --- | ||||||||||
Version: | Latest | ||||||||||
Hardware: | Any | ||||||||||
OS: | Any | ||||||||||
Attachments: |
|
Created attachment 156932 [details]
shar file of the upgrade of port to 2.2
It fails complaining on Electrum-2.2-py%%PYTHON_VER%%.egg-info/* entries. Probably these are handled by python framework and should not be in plist. Do those lines in the plist cause an issue? The files are installed with the package, and are placed in the plist by make makeplist. Having them there doesn't cause any warning or error for me. Unfortunately the "python framework" you refer to seems to be completely undocumented, but if it doesn't like them in the plist I would suggest the framework be updated to not put them in the plist. Created attachment 157031 [details]
Build log
As I've said, in result the port doesn't build, so yes, this creates an issue. See attached log - there's also line that adds them to plist automatically, so egg-info/* should just be removed from normal plist.
I don't get errors, but I do get a duplicate file warning. Somehow I missed that. But to me this is a bug in make makeplist that should be fixed. Otherwise anyone creating a python package has to duplicate the same workaround - removing egg files. Which is wasteful. I'll wait for 2.2.1 as it turns out 2.2 had a couple of unfortunate bugs. (In reply to kyuupichan from comment #5) > But to me this is a bug in make makeplist that should be fixed. Otherwise anyone creating a python package has to duplicate the same workaround - removing egg files. Which is wasteful. There may be a bug in makeplist, but fixing it may be even more wasteful as it may require duplicating some make logic. It is mandatory to test your changes in poudriere before submitting them, and this will reveal problems like this. Please do that with next submission. I'm closing this bug if we're not updating to 2.2. |
Created attachment 156931 [details] Diff of the upgrade of port to 2.2 Simple upgrade to 2.2, just released