Bug 200354

Summary:	games/frotz needs an update to 2.44
Product:	Ports & Packages	Reporter:	David Griffith <dave>
Component:	Individual Port(s)	Assignee:	Dmitry Marakasov <amdmi3>
Status:	Closed FIXED
Severity:	Affects Some People	CC:	amdmi3
Priority:	---
Version:	Latest
Hardware:	Any
OS:	Any

Description David Griffith 2015-05-20 20:59:22 UTC

I just released Frotz 2.44.  It's tagged in Github and will be in its expected spot in the IF Archive mirrors in a few days.  For pkg-descr, please add https://github.com/DavidGriffith/frotz/wiki or https://github.com/DavidGriffith/frotz/ as I'm moving away from Sourceforge.

Also, https://www.freebsd.org/ports/games.html references Frotz 2.43d when what is currently installed in 2.44pre.

Comment 1 Dmitry Marakasov freebsd_committer

2015-05-26 18:41:14 UTC

There's a patch which fixes this compilation error:

src/curses/ux_audio_oss.c:83:13: error: static declaration of 'sigint_handler' follows non-static declaration

https://svnweb.freebsd.org/ports/head/games/frotz/files/patch-src_curses_ux__audio__oss.c?revision=374061&view=co

Is the patch correct? Could it be merged upstream?

Comment 2 commit-hook freebsd_committer

2015-05-26 18:50:43 UTC

A commit references this bug:

Author: amdmi3
Date: Tue May 26 18:50:10 UTC 2015
New revision: 387511
URL: https://svnweb.freebsd.org/changeset/ports/387511

Log:
  - Update to 2.44

  PR:		200354
  Submitted by:	bugs@661.org (upstream maintainer)

Changes:
  head/games/frotz/Makefile
  head/games/frotz/distinfo
  head/games/frotz/pkg-descr

Comment 3 David Griffith 2015-05-26 19:17:12 UTC

I've added Dmitri's patch and tidied up OSS audio output a bit just for yuks.  At this point, OSS output in Frotz is deprecated.  I'm aware of only two games that use old-style sound output: "Sherlock" and "Lurking Horror", both by Infocom.  Everything else uses Blorb files.  This release does use Blorb files, but only for the game file.  

The audio overhaul I'm working on uses libao for output, libsndfile, libogg, and libmodplug for file input, and Blorb for packaging up game file, sound, and so on.

Comment 4 Dmitry Marakasov freebsd_committer

2015-05-26 20:22:39 UTC

Nice, thank you. Also note that there's probably problem with these signal handlers as you have two of them, and if you set one for oss, it replaces main one (sigint_handler). Haven't really checked, but this is likely.