Bug 200430

Summary: devel/rebar: Add bash and zsh completions OPTIONS
Product: Ports & Packages Reporter: Jimmy Olgeni <olgeni>
Component: Individual Port(s)Assignee: Jimmy Olgeni <olgeni>
Status: Closed FIXED    
Severity: Affects Only Me CC: koobs
Priority: --- Keywords: needs-patch, patch
Version: LatestFlags: koobs: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Completion patch
none
poudriere testport run with all options enabled
none
Silence warnings when options are disabled
koobs: maintainer-approval-
poudriere testport run with all options disabled (default) none

Description Jimmy Olgeni freebsd_committer freebsd_triage 2015-05-24 19:31:27 UTC
Created attachment 157103 [details]
Completion patch

New ZSH and BASH options to activate completions.
Comment 1 Jimmy Olgeni freebsd_committer freebsd_triage 2015-05-24 19:32:03 UTC
Created attachment 157104 [details]
poudriere testport run with all options enabled
Comment 2 Jimmy Olgeni freebsd_committer freebsd_triage 2015-05-24 19:41:58 UTC
Created attachment 157105 [details]
Silence warnings when options are disabled
Comment 3 Jimmy Olgeni freebsd_committer freebsd_triage 2015-05-24 19:43:19 UTC
Created attachment 157106 [details]
poudriere testport run with all options disabled (default)
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2015-05-25 04:26:57 UTC
.if ${PORT_OPTIONS:MBASH} and .if ${PORT_OPTIONS:MZSH} can be made into OPTIONS helpers: BASH_PLIST_FILES and ZSH_PLIST_FILES respectively.
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2015-05-25 04:28:14 UTC
Assign to reporter.

Approved to commit with the options helper change outlined in comment 4
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-05-26 13:57:02 UTC
A commit references this bug:

Author: olgeni
Date: Tue May 26 13:56:06 UTC 2015
New revision: 387477
URL: https://svnweb.freebsd.org/changeset/ports/387477

Log:
  Add options for installing bash and zsh completions.

  PR:		200430
  Submitted by:	olgeni
  Approved by:	maintainer

Changes:
  head/devel/rebar/Makefile
Comment 7 Jimmy Olgeni freebsd_committer freebsd_triage 2015-05-26 13:57:33 UTC
Committed - thanks!