Bug 200449

Summary: lang/rust: version 1.0.0 is compiled with "dev" channel
Product: Ports & Packages Reporter: Saghm <saghmrossi>
Component: Individual Port(s)Assignee: Thomas Zander <riggs>
Status: Closed FIXED    
Severity: Affects Some People CC: andoriyu, gleb, koobs, riggs
Priority: --- Keywords: needs-qa
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://users.rust-lang.org/t/stable-versions-of-source-and-linux-binary-differ/1561
Bug Depends on: 201142    
Bug Blocks:    
Attachments:
Description Flags
Proposed change to the Makefile none

Description Saghm 2015-05-25 23:44:12 UTC 
In the source for Rust 1.0.0 downloaded from the official Rust website, if the "release channel" argument in the `configure` script is not set to "stable" before running `./configure`, the developer channel of Rust is compiled instead of stable, which allows use of the unstable portions of the language. Unless this was the intention, the port should probably be updated to default to the stable channel (or maybe the "dev" and "stable" channels should be separated into two different ports?)
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2015-05-26 00:07:21 UTC 
This port currently has no MAINTAINER. Can you provide a patch to that affect?

If so I'd be happy to review it and commit if it looks appropriate.
Comment 2 Saghm 2015-05-26 00:33:48 UTC 
Created attachment 157139 [details]
Proposed change to the Makefile

It's a pretty simple patch, just adding one line to the Makefile
Comment 3 Andrey Cherkashin 2015-06-26 07:31:56 UTC 
(In reply to Saghm from comment #2)
This actually doesn't really matter right now, if you look at configure script — all channels, but nightly behave exactly the same. Worth changing it just in case.
Comment 4 Gleb Kozyrev 2015-06-26 18:59:13 UTC 
+1 to this patch.

Rust developers strive to provide some guarantees of backward compatibility between released versions. To that end they intend the releases to be built on the "stable" channel disallowing the use of "unstable" features. The current selection of the channel ("dev") contradicts that intention, breaks the compatibility promise and arguably is against POLA. The "dev" channel is appropriate for a rust-dev (or rust-nightly) port that would track the bleeding edge.
Comment 5 Thomas Zander freebsd_committer freebsd_triage 2015-06-27 13:19:07 UTC 
I am currently looking into bug 201142. If committed, this would fix this one in the process.
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-06-27 18:27:38 UTC 
A commit references this bug:

Author: riggs
Date: Sat Jun 27 18:26:42 UTC 2015
New revision: 390720
URL: https://svnweb.freebsd.org/changeset/ports/390720

Log:
  - Update to upstream release 1.1.0
  - Fix bug 200449 in the process

  PR:		201142, 200449
  Submitted by:	andoriyu@gmail.com

Changes:
  head/lang/rust/Makefile
  head/lang/rust/distinfo
  head/lang/rust/pkg-plist
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2015-06-28 08:10:00 UTC 
Fixed by riggs in bug 201142