Bug 20063

On Thu, Jul 20, 2000 at 04:23:46PM -0000, Miklos Niedermayer wrote:
> >Number:         20063
> >Category:       ports
> >Synopsis:       New port - MySQL++
> >Confidential:   yes
> >Severity:       serious
> >Priority:       medium

Huh??  Why is this "confidential"??  Why is this serious??  Why should
this be medium priority??

> sed 's/^X//' >mysql++/Makefile << 'END-of-mysql++/Makefile'
> X# ports collection makefile for:	MySQL++
> X# Version required:			1.7

Read the handbook.  This was obsoleted 2 months ago.

> X# Date created:				20th July 2000
> X# Whom:					Miklos Niedermayer <mico@bsd.hu>
> X#
> X# $FreeBSD$
> X#
> X
> XDISTNAME=	mysql++-1.7

See above.

> END-of-mysql++/Makefile
> echo c - mysql++/pkg
> mkdir -p mysql++/pkg > /dev/null 2>&1
> echo x - mysql++/pkg/COMMENT
> sed 's/^X//' >mysql++/pkg/COMMENT << 'END-of-mysql++/pkg/COMMENT'
> XComplex C++ API for MySQL (needs mysql-client)
> END-of-mysql++/pkg/COMMENT
> echo x - mysql++/pkg/DESCR
> sed 's/^X//' >mysql++/pkg/DESCR << 'END-of-mysql++/pkg/DESCR'
> X   Mysql++ is a complex C++ API for Mysql (And other SQL Databases Soon).
> X   The goal of this API is too make working with Queries as easy as
> X   working with other STL Containers.
> X   
> X   The manual can be found at /usr/local/share/doc/mysql++, and there are
> X   some examples in /usr/local/share/examples/mysql++ (see README).
> X
> X   Instructions for joining the mailing list (and an archive of the
> X   mailing list) can be found off the Mysql++ home page at
> X   http://www.mysql.com/download_mysql++.html. If you just wish to ask
> X   questions, you can mail to mysql-plusplus@lists.mysql.com.

See above.  Use WWW: for web addresses.

> sed 's/^X//' >mysql++/patches/patch-aa << 'END-of-mysql++/patches/patch-aa'
> X--- sqlplusint/Makefile.in.orig	Tue May 16 16:21:47 2000
> X+++ sqlplusint/Makefile.in	Thu Jul 20 11:22:08 2000
> X@@ -91,7 +91,7 @@
> X libsqlplus_la_SOURCES = coldata.cc connection.cc datetime.cc field_names.cc field_types.cc manip.cc query.cc result.cc row.cc set.cc sql_query.cc type_info.cc vallist.cc string_util.cc
> X 
> X 
> X-libsqlplus_la_LDFLAGS = -version-info $(SQLPLUS_MAJOR_VERSION):$(SQLPLUS_MINOR_VERSION):$(SQLPLUS_MICRO_VERSION)
> X+libsqlplus_la_LDFLAGS = -version-info $(SQLPLUS_MAJOR_VERSION)

For a simple change like this, I would just use a perl regex to get rid
of the extra cruft.  (This is not documented in the handbook, but IMNSHO
it is preferable to patches which take up more space + inodes in ports).

You need to use portlint on your ports before submitting them.  An
UP-TO-DATE portlint (see ports/devel/portlint).  ;)

In any case, I'll look into adding it to the tree.

-- 
Will Andrews <andrewsw@purdue.edu> <will@FreeBSD.org>
GCS/E/S @d- s+:+>+:- a--->+++ C++ UB++++ P+ L- E--- W+++ !N !o ?K w---
?O M+ V-- PS+ PE++ Y+ PGP+>+++ t++ 5 X++ R+ tv+ b++>++++ DI+++ D+ 
G++>+++ e->++++ h! r-->+++ y?

Comment 2 Will Andrews 2000-07-21 06:07:33 UTC

State Changed
From-To: open->closed

Committed, thanks!