Bug 200640

Summary: [patch] www/speedtest-mini new distinfo required
Product: Ports & Packages Reporter: Adrian Murphy <amurphy>
Component: Individual Port(s)Assignee: TAKATSU Tomonari <tota>
Status: Closed FIXED    
Severity: Affects Only Me CC: meta, tota
Priority: --- Keywords: patch
Version: LatestFlags: meta: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch
none
maintainer patch
meta: maintainer-approval+
maintainer patch
none
poudriere log none

Description Adrian Murphy 2015-06-04 15:59:45 UTC
Created attachment 157411 [details]
patch

updated to 2.1.8.20150605

The mini.zip dist file has changed again so a new distinfo is required.

I removed PORTREVISION and PORTEPOCH from the Makefile. I'm not sure if that is correct.
Comment 1 Koichiro Iwao freebsd_committer freebsd_triage 2015-06-05 00:32:40 UTC
There's some points to be corrected.
- Never decrease/reset PORTEPOCH. This value will be increased when PORTVERSION is decreased.
- Set the date of PORTVERSION of mini.zip, not today.  

$  curl --head http://c.speedtest.net/mini/mini.zip
curl: (3) <url> malformed
HTTP/1.1 200 OK
Accept-Ranges: bytes
Cache-Control: max-age=86400
Content-Type: application/zip
Date: Fri, 05 Jun 2015 00:10:06 GMT
Etag: "2e0635-5e6b84a-50ca21f400ac5"
Expires: Sat, 06 Jun 2015 00:10:06 GMT
Last-Modified: Wed, 14 Jan 2015 19:55:32 GMT <- this!
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 
Server: ECAcc (oxr/8351)
X-Cache: HIT
X-Frame-Options: SAMEORIGIN
X-XSS-Protection: 1; mode=block
Content-Length: 99006538

Anyway, thank you for informing me of that! I will make a new patch.
Comment 2 Koichiro Iwao freebsd_committer freebsd_triage 2015-06-05 00:34:26 UTC
Created attachment 157424 [details]
maintainer patch

I'm only privileged to obsolete my own patch.
Dear committer, please obsolete submitter's patch.
Comment 3 Koichiro Iwao freebsd_committer freebsd_triage 2015-06-05 00:36:06 UTC
Created attachment 157425 [details]
maintainer patch
Comment 4 Koichiro Iwao freebsd_committer freebsd_triage 2015-06-05 00:36:29 UTC
Created attachment 157426 [details]
poudriere log
Comment 5 Adrian Murphy 2015-06-05 05:41:42 UTC
Comment on attachment 157411 [details]
patch

Obseleted as requested
Comment 6 Koichiro Iwao freebsd_committer freebsd_triage 2015-06-17 08:59:10 UTC
call for committer
Comment 7 TAKATSU Tomonari freebsd_committer freebsd_triage 2015-06-17 09:50:10 UTC
I'll take it.
Comment 8 TAKATSU Tomonari freebsd_committer freebsd_triage 2015-06-17 11:43:46 UTC
Committed. Thanks!
Comment 9 commit-hook freebsd_committer freebsd_triage 2015-06-17 12:44:07 UTC
A commit references this bug:

Author: tota
Date: Wed Jun 17 11:02:59 UTC 2015
New revision: 389904
URL: https://svnweb.freebsd.org/changeset/ports/389904

Log:
  - Update to 2.1.8.20150114

  PR:		ports/200640
  Submitted by:	Adrian Murphy <amurphy@gsoft.com.au>
  Reviewed by:	Koichiro IWAO <meta+ports@vmeta.jp> (maintainer)

Changes:
  head/www/speedtest-mini/Makefile
  head/www/speedtest-mini/distinfo