Bug 200646

Summary: [patch] mark www/chromium broken on FreeBSD 8
Product: Ports & Packages Reporter: Don Lewis <truckman>
Component: Individual Port(s)Assignee: freebsd-chromium (Nobody) <chromium>
Status: Closed FIXED    
Severity: Affects Some People CC: emaste, rene
Priority: --- Keywords: patch
Version: LatestFlags: bugzilla: maintainer-feedback? (chromium)
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch to mark chromium broken on FreeBSD 8 none

Description Don Lewis freebsd_committer freebsd_triage 2015-06-04 20:53:34 UTC
Created attachment 157417 [details]
patch to mark chromium broken on FreeBSD 8

The chromium build fails on FreeBSD 8 because of the lack of locale_t.  This is unlikely to be fixed before the FreeBSD 8 EOL, so mark the port broken on FreeBSD 8.

[3831/16858] CXX obj/third_party/skia/src/gpu/gl/builders/skia_library.GrGLProgramBuilder.o
FAILED: g++48 -MMD -MF obj/third_party/skia/src/gpu/gl/builders/skia_library.GrGLProgramBuilder.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DDISABLE_NACL -DCHROMIUM_BUILD -DCR_CLANG_REVISION=233105-1 -DTOOLKIT_VIEWS=1 -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DUSE_PROPRIETARY_CODECS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DDONT_EMBED_BUILD_METADATA -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DSK_SUPPORT_GPU=1 -DSK_LEGACY_DRAWPICTURECALLBACK -DSK_SUPPORT_LEGACY_OPTIONLESS_GET_PIXELS '-DSK_DEFAULT_FONT_CACHE_LIMIT=(20*1024*1024)' -DSK_GAMMA_EXPONENT=1.2 -DSK_GAMMA_CONTRAST=0.2 -DSK_HIGH_QUALITY_IS_LANCZOS -DU_USING_ICU_NAMESPACE=0 -DUSE_LIBPCI=1 -DUSE_GLIB=1 -DUSE_NSS=1 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen/shim_headers/icuuc/target -Igen -I../../third_party/skia/include/c -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/record -I../../third_party/skia/include/utils -I../../third_party/skia/src/core -I../../third_party/skia/src/opts -I../../third_party/skia/src/image -I../../third_party/skia/src/pdf -I../../third_party/skia/src/ports -I../../third_party/skia/src/sfnt -I../../third_party/skia/src/utils -I../../third_party/skia/src/lazy -I../.. -I../../skia/config -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/zlib -fstack-protector --param=ssp-buffer-size=4  -pthread -fno-strict-aliasing -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-unused-local-typedefs -Wno-unused -Wno-unused-function -I/usr/local/include -I/usr/local/include/freetype2 -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/local/include/cairo -I/usr/local/include/pixman-1 -I/usr/local/include/libpng16 -D_THREAD_SAFE -I/usr/local/include/pango-1.0 -pthread -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include -I/usr/local/include/freetype2 -I/usr/local/include/harfbuzz -Wno-format -m64 -march=x86-64 -O2 -fno-ident -fdata-sections -ffunction-sections -funwind-tables -O2 -pipe -isystem/usr/local/include -I/usr/local/include/atk-1.0 -fno-omit-frame-pointer -fno-stack-protector -fstack-protector -Wl,-rpath=/usr/local/lib/gcc48 -fno-strict-aliasing -Wl,-rpath=/usr/local/lib/gcc48 -fno-exceptions -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wno-deprecated -std=gnu++11 -Wno-narrowing -Wno-literal-suffix  -c ../../third_party/skia/src/gpu/gl/builders/GrGLProgramBuilder.cpp -o obj/third_party/skia/src/gpu/gl/builders/skia_library.GrGLProgramBuilder.o
In file included from ../../third_party/skia/src/gpu/gl/builders/GrGLProgramBuilder.cpp:17:0:
../../third_party/skia/src/gpu/GrAutoLocaleSetter.h:58:5: error: 'locale_t' does not name a type
     locale_t fOldLocale;
     ^
../../third_party/skia/src/gpu/GrAutoLocaleSetter.h:59:5: error: 'locale_t' does not name a type
     locale_t fLocale;
     ^
../../third_party/skia/src/gpu/GrAutoLocaleSetter.h: In constructor 'GrAutoLocaleSetter::GrAutoLocaleSetter(const char*)':
../../third_party/skia/src/gpu/GrAutoLocaleSetter.h:32:9: error: 'fLocale' was not declared in this scope
         fLocale = newlocale(LC_ALL, name, 0);
         ^
../../third_party/skia/src/gpu/GrAutoLocaleSetter.h:32:44: error: 'newlocale' was not declared in this scope
         fLocale = newlocale(LC_ALL, name, 0);
                                            ^
../../third_party/skia/src/gpu/GrAutoLocaleSetter.h:34:13: error: 'fOldLocale' was not declared in this scope
             fOldLocale = uselocale(fLocale);
             ^
../../third_party/skia/src/gpu/GrAutoLocaleSetter.h:34:43: error: 'uselocale' was not declared in this scope
             fOldLocale = uselocale(fLocale);
                                           ^
../../third_party/skia/src/gpu/GrAutoLocaleSetter.h: In destructor 'GrAutoLocaleSetter::~GrAutoLocaleSetter()':
../../third_party/skia/src/gpu/GrAutoLocaleSetter.h:46:13: error: 'fLocale' was not declared in this scope
         if (fLocale) {
             ^
../../third_party/skia/src/gpu/GrAutoLocaleSetter.h:47:24: error: 'fOldLocale' was not declared in this scope
              uselocale(fOldLocale);
                        ^
../../third_party/skia/src/gpu/GrAutoLocaleSetter.h:47:34: error: 'uselocale' was not declared in this scope
              uselocale(fOldLocale);
                                  ^
../../third_party/skia/src/gpu/GrAutoLocaleSetter.h:48:32: error: 'freelocale' was not declared in this scope
              freelocale(fLocale);
                                ^
ninja: build stopped: subcommand failed.
*** Error code 1

Stop in /usr/ports/www/chromium.
Comment 1 Ed Maste freebsd_committer freebsd_triage 2015-06-15 13:14:04 UTC
Looks reasonable to me
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-06-26 23:15:10 UTC
A commit references this bug:

Author: rene
Date: Fri Jun 26 23:14:07 UTC 2015
New revision: 390673
URL: https://svnweb.freebsd.org/changeset/ports/390673

Log:
  www/chromium : update to 43.0.2357.130

  * Fix some widely-reported crashes: [0,1]
    - settings page now displays
    - GMail works
  * Mark BROKEN on FreeBSD 8 [2]

  PR:		200601 [0]
  PR:		200646 [2]
  Submitted by:	protocelt <protoceltt@gmail.com> [0]
  Submitted by:	truckman [2]
  Obtained from:	https://github.com/gliaskos/freebsd-chromium [1]
  		(pull requests 17-20)
  MFH:		2015Q2
  Security:	http://vuxml.freebsd.org/freebsd/d46ed7b8-1912-11e5-9fdf-00262d5ed8ee.html

Changes:
  head/www/chromium/Makefile
  head/www/chromium/distinfo
  head/www/chromium/files/patch-base__process__process_info_linux.cc
  head/www/chromium/files/patch-content__browser__time_zone_monitor_linux.cc
  head/www/chromium/files/patch-media__video__capture__fake_video_capture_device_factory.cc
  head/www/chromium/files/patch-media__video__capture__file_video_capture_device_factory.cc
  head/www/chromium/files/patch-media__video__capture__video_capture_device.cc
  head/www/chromium/files/patch-media__video__capture__video_capture_device.h
  head/www/chromium/files/patch-media__video__capture__video_capture_device_factory.cc
  head/www/chromium/files/patch-third_party__webrtc__base__systeminfo.cc
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-06-26 23:26:15 UTC
A commit references this bug:

Author: rene
Date: Fri Jun 26 23:26:05 UTC 2015
New revision: 390677
URL: https://svnweb.freebsd.org/changeset/ports/390677

Log:
  MFH: r390673

  www/chromium : update to 43.0.2357.130

  * Fix some widely-reported crashes: [0,1]
    - settings page now displays
    - GMail works
  * Mark BROKEN on FreeBSD 8 [2]

  PR:		200601 [0]
  PR:		200646 [2]
  Submitted by:	protocelt <protoceltt@gmail.com> [0]
  Submitted by:	truckman [2]
  Obtained from:	https://github.com/gliaskos/freebsd-chromium [1]
  		(pull requests 17-20)
  Security:	http://vuxml.freebsd.org/freebsd/d46ed7b8-1912-11e5-9fdf-00262d5ed8ee.html
  Approved by:	ports-secteam (delphij)

Changes:
_U  branches/2015Q2/
  branches/2015Q2/www/chromium/Makefile
  branches/2015Q2/www/chromium/distinfo
  branches/2015Q2/www/chromium/files/patch-base__process__process_info_linux.cc
  branches/2015Q2/www/chromium/files/patch-content__browser__time_zone_monitor_linux.cc
  branches/2015Q2/www/chromium/files/patch-media__video__capture__fake_video_capture_device_factory.cc
  branches/2015Q2/www/chromium/files/patch-media__video__capture__file_video_capture_device_factory.cc
  branches/2015Q2/www/chromium/files/patch-media__video__capture__video_capture_device.cc
  branches/2015Q2/www/chromium/files/patch-media__video__capture__video_capture_device.h
  branches/2015Q2/www/chromium/files/patch-media__video__capture__video_capture_device_factory.cc
  branches/2015Q2/www/chromium/files/patch-third_party__webrtc__base__systeminfo.cc