Bug 200652

Summary: New port: www/p5-Plack-Middleware-ExtDirect Implement an RPC::ExtDirect gateway using Plack
Product: Ports & Packages Reporter: Martin Waschbüsch <martin>
Component: Individual Port(s)Assignee: Kurt Jaeger <pi>
Status: Closed FIXED    
Severity: Affects Only Me CC: pi, ports
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on: 200709    
Bug Blocks:    
Attachments:
Description Flags
shar file as per porter's handbook
none
shar file as per porter's handbook
none
Output of 'portlint -AC'
none
Output of 'make test' none

Description Martin Waschbüsch 2015-06-05 04:49:09 UTC
Created attachment 157430 [details]
shar file as per porter's handbook

This module provides an RPC::ExtDirect gateway implementation for Plack
environment. It is packaged as a standard Plack middleware component suitable
for using with Plack::Builder.
Comment 1 Martin Waschbüsch 2015-06-08 06:18:02 UTC
This port would complement the ports already existing:
p5-CGI-ExtDirect-3.12
p5-RPC-ExtDirect-3.02
Comment 2 Torsten Zühlsdorff 2015-10-09 12:56:00 UTC
I copy my reply to your message <BAAEFA33-7119-4A3F-AE8F-B7A73A20F547@waschbuesch.de> to ports@freebsd.org as a comment, so we can keep track.

I think you should make a little more QA.

First i see there is a PORTEPOCH. Since this is a new port, this line should not be there.

Also you comment out an build dependency. Better to remove it completely.

It is also a good idea to use "portlint -AC" against the new port and add some poudriere logs, which proves everything works fine.

If you need any help with this, feel free to contact me.

Greetings,
Torsten
Comment 3 Martin Waschbüsch 2015-10-09 13:23:37 UTC
Thanks, Torsten.
Those are some good suggestions.

I have just tried again with a clean build environment, thinking I would produce e.g. a log for 'make test' and 'portlint -AC', but saw that the build failed.

Apparently, I first need to make sure my suggested upgrade of the dependency p5-RPC-ExtDirect (PR 200709) needs to be in place for this new port to work at all.

So, right now, I'll add the dependency on the other PR, mend the Makefile and provide logs for some more QA stuff.

If you have any other suggestions to help me - that would be cool!

Martin
Comment 4 Martin Waschbüsch 2015-10-09 13:45:17 UTC
Created attachment 161847 [details]
shar file as per porter's handbook

updated Makefile to satisfy portlint.
Comment 5 Martin Waschbüsch 2015-10-09 13:45:38 UTC
Created attachment 161848 [details]
Output of 'portlint -AC'
Comment 6 Martin Waschbüsch 2015-10-09 13:45:59 UTC
Created attachment 161849 [details]
Output of 'make test'
Comment 7 Kurt Jaeger freebsd_committer freebsd_triage 2015-10-09 19:29:16 UTC
The shar file is a bit off, but I could find the real Makefile in there 8-}

Testing @work.
Comment 8 commit-hook freebsd_committer freebsd_triage 2015-10-10 11:53:18 UTC
A commit references this bug:

Author: pi
Date: Sat Oct 10 11:52:26 UTC 2015
New revision: 398990
URL: https://svnweb.freebsd.org/changeset/ports/398990

Log:
  New port: www/p5-Plack-Middleware-ExtDirect

  This module provides an RPC::ExtDirect gateway implementation for Plack
  environment. It is packaged as a standard Plack middleware component suitable
  for using with Plack::Builder.

  Plack::Middleware::ExtDirect is recommended to be used with Perl versions 5.12
  and newer, for reasons explained below. For Perls older than 5.12,
  CGI::ExtDirect gateway may be a better choice - especially if you cannot
  install XS dependent packages.

  If you are not familiar with Ext.Direct, more information can be found in
  RPC::ExtDirect::Intro.

  WWW: http://search.cpan.org/dist/Plack-Middleware-ExtDirect/

  PR:		200652
  Submitted by:	martin@waschbuesch.de

Changes:
  head/www/Makefile
  head/www/p5-Plack-Middleware-ExtDirect/
  head/www/p5-Plack-Middleware-ExtDirect/Makefile
  head/www/p5-Plack-Middleware-ExtDirect/distinfo
  head/www/p5-Plack-Middleware-ExtDirect/pkg-descr
  head/www/p5-Plack-Middleware-ExtDirect/pkg-plist
Comment 9 Kurt Jaeger freebsd_committer freebsd_triage 2015-10-10 11:54:05 UTC
Committed, thanks. Testing was fine on the usual platforms, after 200709
was done.