Bug 200685

Summary: [maintainer] www/h2o r387352 breaks 1.0.1 build in branches/2015Q2
Product: Ports & Packages Reporter: Dave Cottlehuber <dch>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Many People CC: portmgr, ports-secteam
Priority: Normal Keywords: easy, needs-qa, patch, patch-ready, regression
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
effectively reverts the patch form r287352 dch: maintainer-approval+

Description Dave Cottlehuber freebsd_committer freebsd_triage 2015-06-06 22:19:53 UTC
the shebangfix applied in r387352 breaks the quarterly
branch as this file is not present until h2o 1.2.0.
Package & port builds on all platforms are failing viz

http://beefy3.nyi.freebsd.org/data/93i386-quarterly/388421/logs/errors/h2o-1.0.1_1.log

```
===>  Extracting for h2o-1.0.1_1
=> SHA256 Checksum OK for h2o-1.0.1.tar.gz.
===========================================================================
=======================<phase: patch-depends  >============================
===========================================================================
=======================<phase: patch          >============================
===>  Patching for h2o-1.0.1_1
sed: share/h2o/start_server: No such file or directory
*** [fix-shebang] Error code 1

Stop in /usr/ports/www/h2o.
```

This commmit should be reverted for this branch only.
Comment 1 Dave Cottlehuber freebsd_committer freebsd_triage 2015-06-06 22:25:07 UTC
Created attachment 157486 [details]
effectively reverts the patch form r287352

Removes only the SHEBANG_FILES line in Makefile and bumps PORTREVISION.
Not clear if ports-secteam need to approve.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2015-06-19 16:26:45 UTC
Assign to committer of revision 387352 for revert
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-06-19 16:51:30 UTC
A commit references this bug:

Author: amdmi3
Date: Fri Jun 19 16:50:55 UTC 2015
New revision: 390134
URL: https://svnweb.freebsd.org/changeset/ports/390134

Log:
  - Revert r388419 unbreaking the build

  PR:		200685
  Submitted by:	dch@skunkwerks.at (maintainer)
  Approved by:	ports-secteam (build fix blanket)

Changes:
  branches/2015Q2/www/h2o/Makefile
Comment 4 Dmitry Marakasov freebsd_committer freebsd_triage 2015-06-19 17:49:49 UTC
Reverted, sorry for the breakage.