Bug 200743
| Summary: | [MAINTAINER] games/minecraft-server: rc.d improvements | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jonathan Price <freebsd> | ||||||||||||||
| Component: | Individual Port(s) | Assignee: | Bartek Rutkowski <robak> | ||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||
| Severity: | Affects Only Me | CC: | robak | ||||||||||||||
| Priority: | --- | ||||||||||||||||
| Version: | Latest | ||||||||||||||||
| Hardware: | Any | ||||||||||||||||
| OS: | Any | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
Created attachment 157581 [details]
Poudriere testport log
Created attachment 157582 [details]
portlint -A output
Created attachment 157603 [details]
Patch File
Incremeneted PORTREVISION
Created attachment 157604 [details]
portlint -A output
Revised portlint after modification to patch.
Created attachment 157605 [details]
Poudriere testport log
Revised Poudriere testport log after revision to Patch file.
A commit references this bug: Author: robak Date: Fri Jun 26 16:22:57 UTC 2015 New revision: 390648 URL: https://svnweb.freebsd.org/changeset/ports/390648 Log: games/minecraft-server: improvements to startup script PR: 200743 Submitted by: Jonathan Price <freebsd@jonathanprice.org> (maintainer) Changes: head/games/minecraft-server/Makefile head/games/minecraft-server/files/minecraft.in Committed, thanks for your work! |
Created attachment 157580 [details] Patch file A few improvements have been made to the rc.d script: - reduced code duplication by adding a function that checks if the server is running, instead of re-writing the check in each other function. - added "kill" option, which sends a KILL signal to the server. - Improved the grammar of a few of the messages The following files have been attached: - SVN patch - portlint -A output - poudriere testport log The change has been tried with both new and existing installations