Summary: | [patch] devel/libvirt: bad BUILD_DEPENDS with sasl support | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | SASAKI Katuhiro <crest> | ||||||
Component: | Individual Port(s) | Assignee: | Jason Helfman <jgh> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Some People | Keywords: | patch | ||||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(jgh) |
||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Description
SASAKI Katuhiro
2015-06-10 02:27:28 UTC
Can you please attach a build log of the port with your patch? Do you use SASL option, or were you just testing the port? If you do you this option, and it builds, is there any functional difference in the port when using it with your patch? Thanks! jgh Created attachment 157733 [details] Log file of building & installing devel/libvirt with environmen security/cyrus-sasl2 already installed. I tested "time (sudo sh -c "make configure && make all -j2 && make deinstall install package clean")" at /usr/ports/devel/libvirt and atattched log file. > Do you use SASL option, or were you just testing the port? > Only testing at now. > If you do you this option, and it builds, is there any functional difference in the port when using it with your patch? If I enable SASL option. Below BUILD_DEPENDS and LIB_DEPENDS are used. -- SASL_BUILD_DEPENDS=sasl:${PORTSDIR}/security/cyrus-sasl2 SASL_LIB_DEPENDS=libsasl2.so:${PORTSDIR}/security/cyrus-sasl2 The later, LIB_DEPENDES does not have any problem. But the former, BUILD_DEPENDS has problem. The security/cyrus-sasl2 port does not install "sasl" executable. So, in the situation security/cyrus-sasl2 is already installed, installing devel/libvirt will always fail. Because, the devel/libvirt determins that security/cyrus-sasl2 is installed or not by checking "sasl" executable is present or not. And it is not present any time. So, devel/libvirt is going to install security/cyrus-sasl2 anyway. Of courese, when security/cyrus-sasl2 is installed, installing security/cyrus-sasl2 runs into error, if FORCE_PKG_REGISTER is not set. These descriptions are about what happens when the errors in attached log file ocurred. From the first, when LIB_DEPENDS is already defined, is there any reason why BUILD_DEPENDS must be defined? Thank you. Thanks for the report! -jgh A commit references this bug: Author: jgh Date: Mon Jun 15 20:52:42 UTC 2015 New revision: 389751 URL: https://svnweb.freebsd.org/changeset/ports/389751 Log: - remove unneeded BUILD_DEPENDS define for SASL option PR: 200752 Submitted by: crest@sahiro.org Changes: head/devel/libvirt/Makefile |