Bug 200764
| Summary: | emulators/virtualbox-ose{,-legacy}: various dependency / bug fixes, convert USE(S) to OPTIONS helpers | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Andriy Voskoboinyk <avos> | ||||||||||||||||||||
| Component: | Individual Port(s) | Assignee: | Vladimir Druzenko <vvd> | ||||||||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||||||||
| Severity: | Affects Only Me | CC: | arrowd, avos, grahamperrin, vbox, vsasjason, vvd | ||||||||||||||||||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(vbox) grahamperrin: maintainer-feedback? (avos) |
||||||||||||||||||||
| Version: | Latest | ||||||||||||||||||||||
| Hardware: | Any | ||||||||||||||||||||||
| OS: | Any | ||||||||||||||||||||||
| URL: | https://reviews.freebsd.org/D40751 | ||||||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||||||
| Bug Blocks: | 187030, 188982, 195365, 201946 | ||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||
Created attachment 157613 [details]
poudriere-10.1-amd64.log.txz
Is there any runtime dependency on libIDL? Created attachment 159668 [details] Patch.diff - Move libIDL and libxslt to build-time dependencies (binaries have no references to them). - Add libxml2 to LIB_DEPENDS. - Fix bug 187030: -- Remove check_xrandr from configure - it is not used here. -- Remove GL/glu.h header check. -- Add dependency for libGL (X11). -- Add an additional check for SDL (x11 field is used by src/VBox/Frontends/VBoxSDL/VBoxSDL.cpp). - Add a workaround for bug 201946, bug 188982 and bug 195365 (field for padding in src/VBox/Devices/Graphics/DevVGA.h (i386 only)). - Use option helpers for *_USE / USES. - Strip shared libraries when DEBUG=off. - Install sdk symbolic link only when PYTHON or WEBSERVICE option is used. - Bump PORTREVISION. Created attachment 159669 [details]
portlint.log
Created attachment 159670 [details]
poudriere.txz
Created attachment 159694 [details]
Patch2.diff
- Fix staging as non-root.
Created attachment 189473 [details]
Patch3.diff
Rebase the patch (+ drop unneeded workaround)
Created attachment 189474 [details]
portlint.log
Created attachment 189475 [details]
poudriere.txz
> - Add a workaround for bug 201946, bug 188982 and bug 195365 (field for padding > in src/VBox/Devices/Graphics/DevVGA.h (i386 only)).
I cannot reproduce this issue with current VirtualBox version (5.2.4); other fixes are still here.
Can this be rebased once more and take into account committed fixes? Triage: * patch is amongst keywords that are deprecated * [patch] is amongst summary line tags that are deprecated * comment #11 requested a rebase … avos@, maybe? Thanks I'll sort out Makefile-s for emulators/virtualbox-ose{,-legacy}.
One more place to fix in emulators/virtualbox-ose:
====> Running Q/A tests (stage-qa)
Warning: Possible REINPLACE_CMD issues:
- - REINPLACE_CMD ran, but did not modify file contents: Config.kmk
- - REINPLACE_CMD ran, but did not modify file contents: configure
- - REINPLACE_CMD ran, but did not modify file contents: kBuild/header.kmk
- - REINPLACE_CMD ran, but did not modify file contents: kBuild/units/qt4.kmk
- - REINPLACE_CMD ran, but did not modify file contents: kBuild/units/qt5.kmk
- - REINPLACE_CMD ran, but did not modify file contents: kBuild/sdks/LIBSDL.kmk
- - REINPLACE_CMD ran, but did not modify file contents: src/libs/xpcom18a4/python/gen_python_deps.py
Why do we need:
do-install:
…
${FIND} . -type f -name "*.so" -exec ${STRIP_CMD} {} \;
if we have:
post-install:
${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/virtualbox/*.so \
${STAGEDIR}${PREFIX}/lib/virtualbox/components/*.so
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=23eed6a75321443d7c6c45b92b28ff0e314e0496 commit 23eed6a75321443d7c6c45b92b28ff0e314e0496 Author: Vladimir Druzenko <vvd@FreeBSD.org> AuthorDate: 2023-06-28 11:57:14 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2023-06-28 12:02:00 +0000 emulators/virtualbox-ose{,-legacy}: sort out options Sort out options: order (portlint), convert to OPTION_*. Add entry in "Troubleshooting" about "VERR_NO_MEMORY". Force devel/llvm15 for emulators/virtualbox-ose-legacy on recent 14 with llvm16 in base. PR: 200764 252227 Approved by: arrowd (mentor) Differential Revision: https://reviews.freebsd.org/D40751 emulators/virtualbox-ose-legacy/Makefile | 98 ++++++++++------------ .../virtualbox-ose-legacy/files/patch-configure | 26 ++++-- emulators/virtualbox-ose-legacy/pkg-message | 30 ++++++- emulators/virtualbox-ose/Makefile | 91 +++++++++----------- emulators/virtualbox-ose/files/patch-configure | 26 ++++-- emulators/virtualbox-ose/files/pkg-message.in | 32 ++++++- 6 files changed, 176 insertions(+), 127 deletions(-) |
Created attachment 157612 [details] Makefile.diff This change significantly reduces number of build dependencies.