Bug 200764

Summary: [patch] emulators/virtualbox-ose: various dependency / bug fixes, convert USE(S) to OPTIONS helpers
Product: Ports & Packages Reporter: Andriy Voskoboinyk <avos>
Component: Individual Port(s)Assignee: Virtualbox Team (Nobody) <vbox>
Status: Open ---    
Severity: Affects Only Me CC: 0mp, arrowd, vsasjason
Priority: --- Keywords: patch
Version: LatestFlags: bugzilla: maintainer-feedback? (vbox)
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 187030, 188982, 195365, 201946    
Attachments:
Description Flags
Makefile.diff
none
poudriere-10.1-amd64.log.txz
none
Patch.diff
none
portlint.log
none
poudriere.txz
none
Patch2.diff
none
Patch3.diff
none
portlint.log
none
poudriere.txz none

Description Andriy Voskoboinyk freebsd_committer 2015-06-10 13:41:30 UTC
Created attachment 157612 [details]
Makefile.diff

This change significantly reduces number of build dependencies.
Comment 1 Andriy Voskoboinyk freebsd_committer 2015-06-10 13:46:48 UTC
Created attachment 157613 [details]
poudriere-10.1-amd64.log.txz
Comment 2 Andriy Voskoboinyk freebsd_committer 2015-06-10 13:53:47 UTC
Is there any runtime dependency on libIDL?
Comment 3 Andriy Voskoboinyk freebsd_committer 2015-08-08 13:51:51 UTC
Created attachment 159668 [details]
Patch.diff

- Move libIDL and libxslt to build-time dependencies (binaries have no references to them).
- Add libxml2 to LIB_DEPENDS.
- Fix bug 187030:
-- Remove check_xrandr from configure - it is not used here.
-- Remove GL/glu.h header check.
-- Add dependency for libGL (X11).
-- Add an additional check for SDL (x11 field is used by src/VBox/Frontends/VBoxSDL/VBoxSDL.cpp).
- Add a workaround for bug 201946, bug 188982 and bug 195365 (field for padding in src/VBox/Devices/Graphics/DevVGA.h (i386 only)).
- Use option helpers for *_USE / USES.
- Strip shared libraries when DEBUG=off.
- Install sdk symbolic link only when PYTHON or WEBSERVICE option is used.
- Bump PORTREVISION.
Comment 4 Andriy Voskoboinyk freebsd_committer 2015-08-08 13:54:13 UTC
Created attachment 159669 [details]
portlint.log
Comment 5 Andriy Voskoboinyk freebsd_committer 2015-08-08 13:55:50 UTC
Created attachment 159670 [details]
poudriere.txz
Comment 6 Andriy Voskoboinyk freebsd_committer 2015-08-09 15:36:51 UTC
Created attachment 159694 [details]
Patch2.diff

- Fix staging as non-root.
Comment 7 Andriy Voskoboinyk freebsd_committer 2018-01-06 21:28:45 UTC
Created attachment 189473 [details]
Patch3.diff

Rebase the patch (+ drop unneeded workaround)
Comment 8 Andriy Voskoboinyk freebsd_committer 2018-01-06 21:29:37 UTC
Created attachment 189474 [details]
portlint.log
Comment 9 Andriy Voskoboinyk freebsd_committer 2018-01-06 21:30:17 UTC
Created attachment 189475 [details]
poudriere.txz
Comment 10 Andriy Voskoboinyk freebsd_committer 2018-01-06 21:35:46 UTC
> - Add a workaround for bug 201946, bug 188982 and bug 195365 (field for padding > in src/VBox/Devices/Graphics/DevVGA.h (i386 only)).

I cannot reproduce this issue with current VirtualBox version (5.2.4); other fixes are still here.
Comment 11 Gleb Popov freebsd_committer 2020-04-25 14:46:23 UTC
Can this be rebased once more and take into account committed fixes?