Bug 200783

Summary: lang/mono: Don't require /proc
Product: Ports & Packages Reporter: Marcin Cieślak <saper>
Component: Individual Port(s)Assignee: David Naylor <dbn>
Status: Closed Overcome By Events    
Severity: Affects Only Me CC: dbn, koobs, mono
Priority: --- Keywords: easy, needs-patch, needs-qa
Version: LatestFlags: bugzilla: maintainer-feedback? (mono)
Hardware: Any   
OS: Any   
URL: https://github.com/mono/mono/pull/1863
Attachments:
Description Flags
Patch to mono/io-layer/processes.c none

Description Marcin Cieślak 2015-06-11 08:56:16 UTC
I have re-used existing OpenBSD code, which uses almost the same interfaces as FreeBSD.

With this patch there is no need to mount /proc at least to run nunit. (Probably /proc is not needed anymore).

More testing welcome!
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2015-06-11 12:07:13 UTC
Hi Marcin, thanks for your submission.

Can you attach the patch as a unified diff against the existing port version, so that we can review it and progress the issue forward

Please also include QA results (as attachments):

 * portlint -AC
 * poudriere testport (or bulk -t)
Comment 2 Marcin Cieślak 2015-06-11 12:20:26 UTC
Created attachment 157634 [details]
Patch to mono/io-layer/processes.c

The full patch attached. The change has been partially merged into upstream master as https://github.com/mono/mono/pull/1863, there rest is there as
https://github.com/mono/mono/pull/1864
Comment 3 Marcin Cieślak 2015-06-11 12:22:47 UTC
Please note that these patches are against git master. I didn't apply them yet on top of the port. (we are not yet finished with https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200690)
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2015-06-15 06:22:52 UTC
Thanks Marcin, though changesets proposed for the ports need to be against our repository (ie; the port) not the upstream sources in order to progress.

In order to progress, this issue needs those patches against the ports tree and QA results as per comment 1
Comment 5 David Naylor freebsd_committer freebsd_triage 2016-12-10 20:53:01 UTC
Both merge request to upstream have been accepted and are now in ports.