Bug 200824
| Summary: | [MAINTAINER] x11/libfm: convert to master-slave; add missing header | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Horia Racoviceanu <horia> | ||||||||||||
| Component: | Individual Port(s) | Assignee: | Thomas Zander <riggs> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Only Me | CC: | olivierd, riggs | ||||||||||||
| Priority: | --- | Keywords: | patch, patch-ready | ||||||||||||
| Version: | Latest | ||||||||||||||
| Hardware: | Any | ||||||||||||||
| OS: | Any | ||||||||||||||
| Bug Depends on: | 200825 | ||||||||||||||
| Bug Blocks: | |||||||||||||||
| Attachments: |
|
||||||||||||||
Linked with Bug 200825 (In reply to Horia Racoviceanu from comment #0) I think it's wrong. There's circular dependencies. x11/libfm-extra (and only this library) is required by x11/menu-cache >= 1.0.0 and menu-cache is needed by x11/libfm in order to build this port. I think split is a best thing. Furthemore, patch-configure is needed if someone doesn't build NLS support, if you remove this patch, traductions are always installed. Created attachment 157776 [details]
libfm.diff
- Convert x11/libfm and x11/libfm-extra to Master-Slave Port
(same application, CATEGORIES, DISTFILES, install path)
- Bump PORTREVISION
- Add missing fm-actions header
- Move patches to Makefile
* Add missing NLS patch-configure
NLS related files were built and installed in STAGEDIR when the NLS option
was disabled, but OPTIONS_SUB=yes prevented them to `make install` on host.
# portlint -AC
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
WARN: Makefile: unless this is a master port, COMMENT has to be set by "=", not by "?=".
0 fatal errors and 3 warnings found.
Created attachment 157777 [details]
Build log: libfm-1.2.3_1-10amd64.log
Created attachment 157778 [details]
Build log: menu-cache-1.0.0-10amd64.log
Created attachment 157779 [details]
Build log: libfm-extra-1.2.3_1-10amd64.log
(In reply to Olivier Duchateau from comment #2) Dependencies are not affected by this patch and Bug 200825. They remain the same: build logs testing Bug 200824 and Bug 200825 simultaneously. It only converts to master-slave. Your NLS patch-configure is needed and I included it in attachment 157776 [details] A commit references this bug: Author: riggs Date: Sat Aug 1 10:15:52 UTC 2015 New revision: 393393 URL: https://svnweb.freebsd.org/changeset/ports/393393 Log: - Convert x11/libfm and x11/libfm-extra to Master-Slave Port (same application, CATEGORIES, DISTFILES, install path) - Bump PORTREVISION - Add missing fm-actions header - Move patches to Makefile PR: 200824 Submitted by: horia@racoviceanu.com (maintainer) Changes: head/x11/libfm/Makefile head/x11/libfm/files/ head/x11/libfm/pkg-plist |
Created attachment 157686 [details] libfm.diff - Convert x11/libfm and x11/libfm-extra to Master-Slave Port (same application, CATEGORIES, DISTFILES, install path) - Bump PORTREVISION - Add missing fm-actions header - Move patches to Makefile