Bug 200924

Summary: audio/wavegain: mark ONLY_FOR_ARCHS, simplify
Product: Ports & Packages Reporter: Dmitry Marakasov <amdmi3>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Some People CC: darcsis
Priority: --- Flags: bugzilla: maintainer-feedback? (darcsis)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch none

Description Dmitry Marakasov freebsd_committer freebsd_triage 2015-06-16 23:40:57 UTC
- Mark ONLY_FOR_ARCHS=i386 amd64, as it uses x86 assembly. There's only single function (lrint), and it is possible that libc lrint(3) may be used instead, thus removing this limitation. Would be nice for maintainer to check that possibility.
- Simplify build: instead of copying, then patching, then patching again with REINPLACE_CMD the Makefile, just run one-line build command used in it directly
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2015-06-16 23:41:43 UTC
Created attachment 157818 [details]
Patch
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-07-01 17:24:41 UTC
A commit references this bug:

Author: amdmi3
Date: Wed Jul  1 17:23:53 UTC 2015
New revision: 391081
URL: https://svnweb.freebsd.org/changeset/ports/391081

Log:
  - Mark ONLY_FOR_ARCHS, uses x86 assembly
  - Simplify Makefile

  PR:		200924
  Submitted by:	amdmi3
  Approved by:	maintainer timeout (darcsis@gmail.com, 2 weeks)

Changes:
  head/audio/wavegain/Makefile
  head/audio/wavegain/files/patch-Makefile.linux