Bug 200931
| Summary: | [PATCH] security/keepass: Make xsel optional | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Sascha Holzleiter <sascha> |
| Component: | Individual Port(s) | Assignee: | Pawel Pekala <pawel> |
| Status: | Closed FIXED | ||
| Severity: | Affects Some People | CC: | pawel, woodsb02 |
| Priority: | --- | Keywords: | patch |
| Version: | Latest | Flags: | woodsb02:
maintainer-feedback+
|
| Hardware: | Any | ||
| OS: | Any | ||
| Attachments: | |||
Created attachment 157832 [details]
Patch to convert xdotool and xsel runtime dependencies to options
Thanks for your feedback. I have made a slight improvement on your proposal to also convert the xdotool runtime dependency to an option.
Other than that, I have tested that this works and am happy for this change to be committed.
Created attachment 157833 [details]
Successful poudriere testport logs with options xsel=on and xdotool=on
Created attachment 157834 [details]
Successful poudriere testport logs with options xsel=off and xdotool=off
Created attachment 157835 [details]
Successful poudriere testport logs with options xsel=off and xdotool=on
Created attachment 157836 [details]
Successful poudriere testport logs with options xsel=on and xdotool=off
A commit references this bug: Author: pawel Date: Fri Jun 26 19:49:16 UTC 2015 New revision: 390665 URL: https://svnweb.freebsd.org/changeset/ports/390665 Log: - Make xsel run dependency optional - it makes clipboard pasting not working under some conditions [1] - Make xdotool also optional - Add NO_ARCH PR: 200931 [1] Submitted by: Sascha Holzleiter <sascha@root-login.org> [1] Approved by: maintainer [1] Changes: head/security/keepass/Makefile |
Created attachment 157829 [details] XSEL option patch For me and others i know of the installation of the xsel dependency keeps KeePass from working. Maybe it's the desktop environment or something else but with xsel i get only an empty clipboard when copying usernames or passwords. Without xsel everything works as expected. So I propose to make xsel an optional dependency. The following patch does exactly that and sets the option as default so the default behavior of the port does not change.