Bug 200935
| Summary: | [MAINTAINER] lang/nim: Update to 0.11.2 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Neal Nelson <ports> | ||||
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||
| Status: | Closed Overcome By Events | ||||||
| Severity: | Affects Only Me | CC: | koobs, ports, ports | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | Latest | Flags: | ports:
maintainer-feedback+
|
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203981 | ||||||
| Attachments: |
|
||||||
This doesn't seem to respect CC thus fails on 8.x: ===> Building for nim-0.11.2 cd /wrkdirs/usr/ports/lang/nim/work/nim-0.11.2 && /usr/bin/env CC="cc" LINKER="cc" COMP_FLAGS=" -O2 -pipe -fstack-protector -fno-strict-aliasing" LINK_FLAGS=" -fstack-protector" /bin/sh build.sh clang -O2 -pipe -fstack-protector -fno-strict-aliasing -Ic_code -c c_code/5_2/nimsrc_nim.c -o c_code/5_2/nimsrc_nim.o clang: not found Hello, i wrote an update for this port today, too: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203981 The patches are not complete duplicates. My patch pets the actual portlint -C and is tested with poudriere for 10.2, 10.1 and 9.3 AMD. Everything worked. Since 8.x is no longer supported the problem Dmitry found, should be not a blocker. Greetings, Torsten @Torsten, if there are any changes here that aren't included in bug 203981, then you should include them there. Unfortunately now that that issue has been marked patch-ready, its probably best to leave it as is. The alternative is that Neal will need to update this patch here to account for the changes in bug 203981 once they're committed, making it more difficult and time consuming. TLDR: If you're aware of a pre-existing issue w/ patch, include it's changes (where appropriate and correct) in any new issue patch, so that the old may be closed as superseded. (In reply to Kubilay Kocak from comment #3) > @Torsten, if there are any changes here that aren't included in bug 203981, >then you should include them there. Unfortunately now that that issue has been > marked patch-ready, its probably best to leave it as is. Everything here is also included in 203981. In my opinion this PR can be closed as superseded. I will make this clear next time. :) @Neal, confirm superseded? This has all been taken care of in the other PR. Superseded by bug 203981 |
Created attachment 157837 [details] Diffs to update lang/nim to 0.11.2 Update of lang/nim to 0.11.2.