Bug 200953
| Summary: | Fix www/awstats compatibility with perl 5.22 | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Adam Weinberger <adamw> | ||||||||||||
| Component: | Individual Port(s) | Assignee: | Adam Weinberger <adamw> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Only Me | CC: | samm, takefu | ||||||||||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(samm) |
||||||||||||
| Version: | Latest | ||||||||||||||
| Hardware: | Any | ||||||||||||||
| OS: | Any | ||||||||||||||
| Attachments: |
|
||||||||||||||
Created attachment 159035 [details]
Update 7.4
Update and problem-solving.
Created attachment 159038 [details]
Update 7.4
There are a bunch of @dirrm's in the plist. At minimum those should become @dir, and ideally they should be removed. Created attachment 159057 [details]
Update 7.4
Fix @dirrm -> @dir
Created attachment 159058 [details]
Update 7.4
(In reply to takefu from comment #4) remove @dir A commit references this bug: Author: adamw Date: Sat Aug 15 16:39:06 UTC 2015 New revision: 394330 URL: https://svnweb.freebsd.org/changeset/ports/394330 Log: Update to 7.4. Also included: - Fix warnings in perl 5.22 - Honour ${WWWDIR} in plist - Sort USES - Fix some trailing spaces in the Makefile PR: 200953 Submitted by: takefu@airport.fm Approved by: maintainer timeout Changes: head/www/awstats/Makefile head/www/awstats/distinfo head/www/awstats/files/patch-awstats.model.conf head/www/awstats/files/patch-tools-awstats_buildstaticpages.pl head/www/awstats/files/patch-tools-awstats_configure.pl head/www/awstats/files/patch-tools-awstats_updateall.pl head/www/awstats/files/patch-wwwroot_cgi-bin_awstats.pl head/www/awstats/pkg-plist Thanks. I committed everything except changing WWW in pkg-descr, which served no purpose. In a separate commit I changed WWW to awstats.org instead. |
Created attachment 157862 [details] 5.22 warnings Under perl 5.22, awstats produces the following warnings: Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/\"%{ <-- HERE Referer}i\"/ at /usr/local/www/awstats/cgi-bin/awstats.pl line 8986. Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/\"%{ <-- HERE User-Agent}i\"/ at /usr/local/www/awstats/cgi-bin/awstats.pl line 8987. Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/%{ <-- HERE mod_gzip_input_size}n/ at /usr/local/www/awstats/cgi-bin/awstats.pl line 8988. Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/%{ <-- HERE mod_gzip_output_size}n/ at /usr/local/www/awstats/cgi-bin/awstats.pl line 8989. Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/%{ <-- HERE mod_gzip_compression_ratio}n/ at /usr/local/www/awstats/cgi-bin/awstats.pl line 8990. Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/\(%{ <-- HERE ratio}n\)/ at /usr/local/www/awstats/cgi-bin/awstats.pl line 8991. Attached patch fixes it. I haven't tested it against perl 5.18/5.20 but I don't think it'd create any problems there.