Bug 200970
| Summary: | databases/mysql56-client -- r389659 should apply to only HEAD | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jeremy Chadwick <jdc> |
| Component: | Individual Port(s) | Assignee: | Alex Dupre <ale> |
| Status: | Closed Works As Intended | ||
| Severity: | Affects Many People | Flags: | bugzilla:
maintainer-feedback?
(ale) |
| Priority: | --- | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
stock system libedit lacks unicode support I'm going to close this bug/PR, but I will say the following (and this is in spirit of what dougb@ would say): 1. Commit message mentions absolutely nothing about Unicode support being the reason for the change, only that "this unbreaks head". Said with utmost respect: being more clear in commit messages in the future would be much appreciated. 2. Nothing else changed in mysql56-* to justify the need for Unicode support on non-CURRENT/non-HEAD systems. Keyword: need. USES+=readline works fine there; yes I'm quite aware editline(3) on 9.x does not support Unicode. 3. Base system libedit in 9.x and 10.x could be upgraded to version that supports Unicode. This is not a task for ports folk, but the result would simplify this pain. |
Recent change to databases/mysql56-{client,server}: http://svnweb.freebsd.org/ports?view=revision&revision=389659 The commit message explicitly states that this workaround is for HEAD. However, the committer applied this universally, so now FreeBSD 8.x, 9.x, 10.x, etc. all pull in libedit as a dependency (when on 9.x and possibly others this is entirely unnecessary; stock system libedit works fine there). Rephrased: if this workaround is needed for just HEAD then there should be an ${OSVERSION} check surrounding this logic, or the version comparison for libedit needs to be adjusted. Proof that this affects 9.x: # pkg upgrade mysql56-client Updating FreeBSD repository catalogue... FreeBSD repository is up-to-date. All repositories are up-to-date. The following 2 package(s) will be affected (of 0 checked): New packages to be INSTALLED: libedit: 3.1.20150325_1 Installed packages to be UPGRADED: mysql56-client: 5.6.24 -> 5.6.24_1 ... $ ls -ld /usr/lib/libedit* /usr/local/lib/libedit* -r--r--r-- 1 root wheel 217398 Jun 12 06:02 /usr/lib/libedit.a lrwxr-xr-x 1 root wheel 17 Jun 12 06:02 /usr/lib/libedit.so -> /lib/libedit.so.7 -r--r--r-- 1 root wheel 227174 Jun 12 06:02 /usr/lib/libedit_p.a -rw-r--r-- 1 root wheel 343502 Jun 13 12:11 /usr/local/lib/libedit.a lrwxr-xr-x 1 root wheel 17 Jun 13 12:11 /usr/local/lib/libedit.so -> libedit.so.0.0.53 lrwxr-xr-x 1 root wheel 17 Jun 13 12:11 /usr/local/lib/libedit.so.0 -> libedit.so.0.0.53 -rwxr-xr-x 1 root wheel 217656 Jun 13 12:11 /usr/local/lib/libedit.so.0.0.53 Footnote: bugs 179841 or 197491 may be related to this too.