Bug 200985

Summary:	sys/dev/hwpmc/hwpmc_piv.c:812: bad assert ?
Product:	Base System	Reporter:	David Binderman <dcb314>
Component:	kern	Assignee:	freebsd-bugs (Nobody) <bugs>
Status:	Closed Overcome By Events
Severity:	Affects Some People	CC:	gonzo
Priority:	---	Keywords:	hwpmc
Version:	10.1-RELEASE
Hardware:	Any
OS:	Any

Description David Binderman 2015-06-20 08:31:29 UTC

sys/dev/hwpmc/hwpmc_piv.c:812]: (warning) Logical disjunction always evaluates to true: cfgflags >= 0 || cfgflags <= 3

   KASSERT(cfgflags >= 0 || cfgflags <= 3,

Maybe

   KASSERT(cfgflags >= 0 && cfgflags <= 3,

Comment 1 David Binderman 2015-06-20 08:34:00 UTC

Same thing at line 838

   KASSERT(cfgflags >= 0 || cfgflags <= 3,

Comment 2 Hiren Panchasara freebsd_committer

2015-06-20 17:04:54 UTC

David,

Your analysis looks correct to me.

Comment 3 Oleksandr Tymoshenko freebsd_committer

2018-07-16 01:36:53 UTC

File was removed in base r334456