Bug 200986

Summary:	sys/dev/isci/scil/scif_sas_controller.c:531: bad if ?
Product:	Base System	Reporter:	David Binderman <dcb314>
Component:	misc	Assignee:	freebsd-bugs (Nobody) <bugs>
Status:	Closed FIXED
Severity:	Affects Some People	CC:	avos
Priority:	---
Version:	10.1-RELEASE
Hardware:	Any
OS:	Any

Description David Binderman 2015-06-20 08:35:20 UTC

sys/dev/isci/scil/scif_sas_controller.c:531]: (warning) Logical conjunction always evaluates to false: EXPR < 1 && EXPR > 32.

 if (scif_parms->sas.max_ncq_depth < 1 && scif_parms->sas.max_ncq_depth > 32)

Maybe

 if (scif_parms->sas.max_ncq_depth < 1 || scif_parms->sas.max_ncq_depth > 32)

Comment 1 Andriy Voskoboinyk freebsd_committer

2019-02-07 13:50:05 UTC

Fixed in base r315205.