Bug 200987

Summary:	sys/dev/ixgbe/ixgbe.c:1058: bad if statement ?
Product:	Base System	Reporter:	David Binderman <dcb314>
Component:	misc	Assignee:	freebsd-bugs (Nobody) <bugs>
Status:	Closed FIXED
Severity:	Affects Some People	CC:	sbruno
Priority:	---	Keywords:	IntelNetworking
Version:	10.1-RELEASE
Hardware:	Any
OS:	Any

Description David Binderman 2015-06-20 08:37:58 UTC

sys/dev/ixgbe/ixgbe.c:1058]: (warning)
 Logical disjunction always evaluates to true: EXPR != 160 || EXPR != 162.

   if ((i2c.dev_addr != 0xA0) || (i2c.dev_addr != 0xA2)){

Maybe

   if ((i2c.dev_addr != 0xA0) && (i2c.dev_addr != 0xA2)){

Comment 1 Sean Bruno freebsd_committer

2015-06-30 16:32:16 UTC

When the ixgbe driver was split and refactored, this line (now in if_ix.c) was changed to:

                if (i2c.dev_addr != 0xA0 && i2c.dev_addr != 0xA2) {