Bug 200989

Summary:	usr.sbin/ppp/mppe.c:171: bad if statement ?
Product:	Base System	Reporter:	David Binderman <dcb314>
Component:	misc	Assignee:	freebsd-bugs (Nobody) <bugs>
Status:	Closed FIXED
Severity:	Affects Some People	CC:	avos
Priority:	---
Version:	10.1-RELEASE
Hardware:	Any
OS:	Any

Description David Binderman 2015-06-20 08:46:20 UTC

usr.sbin/ppp/mppe.c:171]: (warning) Logical conjunction always evaluates to false: EXPR < 33 && EXPR > 250.

  if (*proto < 0x21 && *proto > 0xFA) {

Maybe

  if (*proto < 0x21 || *proto > 0xFA) {

Comment 1 Andriy Voskoboinyk freebsd_committer

2019-02-07 13:58:11 UTC

Fixed in base r256574.