Bug 201035

Summary: Accept more than one maintainer for ports (and issues in bugzilla)
Product: Ports & Packages Reporter: sasamotikomi
Component: Ports FrameworkAssignee: Port Management Team <portmgr>
Status: Closed Not Accepted    
Severity: Affects Many People CC: erwin, koobs, portmaster, ports-bugs
Priority: --- Keywords: feature
Version: Latest   
Hardware: Any   
OS: Any   

Description sasamotikomi 2015-06-22 05:27:59 UTC
Will be good to have more than one maintainer in Bugzilla tickets and Ports.
It is solve the problem if someone has not received notification(haven't mail-lists subscribe or have different email)
For example:
maintainer_team=team@freebsd.org
maintainer_committer=committer@freebsd.org, committer2@freebsd.org
maintainer_contributor=contributor@gmail.com, contributor2@gmail.com
Or even by part of one port (if 
impossible do port modular )
For example:
maintainer_opengl=committer@freebsd.org, contributor@gmail.com
maintainer_openal=contributor@gmail.com
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2015-08-05 13:56:08 UTC
This is a feature request, and will require some initial and further thought and discussion about:

 * how it could/should be implemented
 * what the benefits and risks might be
 * potential impact on consumers (users and systems) that utilize MAINTAINER in its current form.

This is definitely within the remit of the Ports Management team, thus will be re-classified/assigned accordingly.

I would strongly recommend/suggest you create (along with feedback from others) a detailed proposal summary in Gist or Wiki page format, that goes over the details.

A format similar to a Python Enhancement Proposal (PEP) would be a good starting point.
Comment 2 Mathieu Arnold freebsd_committer freebsd_triage 2015-08-05 15:16:37 UTC
The maintainer is the primary caretaker of a port, not the exclusive owner. That being said...

What problem are you trying to solve ?
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2015-08-05 15:29:28 UTC
I can think of a few cases I might like to declare/codify:

- Shared maintainership (primary, secondary)
- Primary individual + Secondary group/team (Eg: + Anyone on python@)
- Primary maintainer, plus some MAINTAINER_POLICY= (values TBD, eg: "open") so that timeout or my feedback isn't required
- Multiple maintainers for large/complex ports that don't warrant, need group/team aliases, etc

I'm sure there are others.
Comment 4 Mathieu Arnold freebsd_committer freebsd_triage 2015-08-05 15:34:58 UTC
I think this is a bad case of over-engineering.
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2015-08-05 15:44:26 UTC
To support declaring the notion of multiple people (many, ideally) maintaining a port/package is over-engineering? The previous comment is talking only about goals, not implementations.

We talk about improving productivity of ports/packages, updates, testing, etc, and I will grant that these things are all possible whilst having a single maintainer.

I also think think everyone would agree there is something very satisfying about 'being' a maintainer that is conducive to contributing in more tangible ways. It is this that is the essence of positive 'ownership' that isn't the negative kind (territoriality) that some people get stuck on.

This shared notion of maintainership shouldn't be limited to one person. And again, the claim is *not* that MAINTAINER is an exclusive lock/owner, is it that there is merit to being able to describe more than just a single maintainer, for various reasons.
Comment 6 Chris Hutchinson 2015-08-05 19:22:10 UTC
Honestly, my first impression was; WHAT?! you've got to be kidding.
So I resisted the temptation to "react". :)
After having given some "objective" thought...
In my personal opinion, this adds additional complexity which
is ultimately counter-productive to the current ports system.
That said. I *do* appreciate the OP's objective, and I think
the simplest solution would be for a "team" to adopt a pseudo
name, and setup a mail address "my-port-team@some-mail-exchanger".
Where each of the members could gain access to the mailings, and
they could subscribe their pseudo name to the relevant mailing
list(s). Then there wouldn't be a "single point of failure",
as the OP seems to suggest the primary problem lies. This would
also give them the opportunity to communicate with each other,
as a group.

Just my humble thoughts on the matter.

All the best.

--Chris
Comment 7 Erwin Lansing freebsd_committer freebsd_triage 2015-08-06 07:58:18 UTC
I'm going to go ahead and take the big hammer and close this.  This comes up every year or so, and while it may add some more flexibility in some cases, most of them can be solves with a single maintainer address listed in the port as well.  Flexibility comes at a cost of having to maintain the flexibility.

Designing and implementing a working solution, that takes care of all corner cases, will be a major task that does not add enough benefit compared to the work that needs to be done.  Also remember, that a lot of downstream code (freshports, portsmon, etc.) assume there to be only one maintainer, and these projects also need to be adjusted.

If you can present a more concrete use-case that cannot be done with a single maintainer, and a implementation and migration plan, including downstream projects, we may reconsider.  But for now, I'd say we have biggest fish to catch.